[mono] merge wasm-threading-eventpipe into main #68232

lambdageek · 2022-04-19T21:01:13Z

Merge initial work on multi-threaded WebAssembly.

The normal wasm build is single-threaded. There should be no functional changes to its behavior.

To enable a multi-threaded build pass /p:WasmEnableThreads=true. See src/mono/wasm/threads.md for details.

The big changes are:

The normal ref assemblies related to threading retain [UnsupportedOSPlatform("browser")] attributes for various threading-related functions
In System.Private.CoreLib, the [UnsupportedOSPlatform] attributes are removed, and functions that used to always throw PNSE nwo do a runtime check using System.Threading.Thread.IsThreadStartSupported to check if threading is enabled in the current build.
A new nuget Microsoft.NET.WebAssembly.Threading is created. It contains experimental ref assemblies without the [UnsupportedOSPlatform] attributes. The intention is that code opting into experimenting with multithreading will include this nuget by setting some property that will be used by the wasm MSBuild SDK to pick a multi-threaded runtime build and configure things appropriately. (The SDK updates don't exist yet).
In the multi-threaded runtime we don't use Emscripten's "main thread" option (ie: the browser thread is the main one); we also continue to run certain runtime-internal jobs (finalizers, GC pump) on the main thread even in the multi-threaded runtime.

Remaining work is tracked in the related issue #68162

Co-authored-by: Zoltan Varga <vargaz@gmail.com>

src/mono/mono/mini/mini-runtime.c:3407:25: error: ‘invoke’ undeclared (first use in this function); did you mean ‘revoke’? 3407 | invoke = mono_marshal_get_runtime_invoke_dynamic ();

Environment setting https://github.com/emscripten-core/emscripten/blob/2.0.34/src/settings.js#L616-L641 From emscripten 2.0.25 release notes - Support for the 'shell' environment is now disabled by default. Running under `d8`, `js`, or `jsc` is not something that most emscripten users ever want to do, so including the support code is, more often than not, unnecessary. Users who want shell support can enable it by including 'shell' in `-s ENVIRONMENT` (dotnet#14535). Example of the the size increase for bench sample: -a--- 12/10/2021 3:35 PM 382113 dotnet.js -a--- 12/13/2021 10:37 AM 383589 dotnet.js

…-34-bump

https://github.com/emscripten-core/emscripten/blob/2fda25eea756c78c8cb024aa5b6c2b188bf7990f/src/settings.js#L1173-L1176 -s EXPORT_ES6 is link option

…-34-bump

To enable, pass `/p:WasmEnableThreads` when building the runtime ./build.sh -Subset mono+libs -os Browser -arch wasm /p:WasmEnableThreads=true

… that worker initialization can find dotnet.js

…roperly get a Module instance, since we broke the API

…have a retval

fixes aot compilation

steveisok

Great job putting this together!

lambdageek · 2022-04-25T19:01:51Z

/azp run runtime-wasm

azure-pipelines · 2022-04-25T19:02:07Z

Azure Pipelines successfully started running 1 pipeline(s).

ViktorHofer

Infrastructure changes LGTM. Good work 👍

lambdageek · 2022-04-25T20:09:49Z

/azp run runtime-wasm

azure-pipelines · 2022-04-25T20:10:05Z

Azure Pipelines successfully started running 1 pipeline(s).

lambdageek · 2022-04-26T01:52:57Z

/azp run runtime-wasm

azure-pipelines · 2022-04-26T01:53:11Z

Azure Pipelines successfully started running 1 pipeline(s).

lateralusX

LGTM!

lateralusX · 2022-04-26T07:33:14Z

src/mono/mono/eventpipe/CMakeLists.txt

@@ -10,9 +10,9 @@ if(ENABLE_PERFTRACING)
        add_definitions(-DENABLE_PERFTRACING_PAL_TCP)
    endif (FEATURE_PERFTRACING_PAL_TCP)

-    if (FEATURE_PERFTRACING_DISABLE_LISTEN_PORTS)


Why was this needed?

this is a fix for a typo, the old cmake variable name was unused

lateralusX · 2022-04-26T07:41:01Z

src/mono/wasm/threads.md

+
+## Building ##
+
+Build with `/p:WasmEnableThreads=true` to enable support for multi-threading.


Will this also enable EventPipe diagnostics support?

I think so. Once we have full user-visible multithreading there's no particular reason to exclude eventpipe.

akoeplinger

LGTM thank you! Found just one small formatting nit.

akoeplinger · 2022-04-26T13:39:58Z

src/libraries/System.Private.CoreLib/src/System/Threading/Thread.cs

+#endif
+#endif
+
+        internal static void ThrowIfNoThreadStart() {


nit: formatting: curly brace on new line

lewing · 2022-04-26T19:30:25Z

🎊

radekdoulik and others added 30 commits December 7, 2021 21:46

Initial changes for emscripten 2.0.34

0a6c904

Use emcc-link.rsp in build targets

1c2f989

Use updated docker images

f74d8b9

Fix compiler warnings

20f59e5

Co-authored-by: Zoltan Varga <vargaz@gmail.com>

Put --profiling-funcs to _EmccLinkFlags

31197d9

Fix build

2063241

src/mono/mono/mini/mini-runtime.c:3407:25: error: ‘invoke’ undeclared (first use in this function); did you mean ‘revoke’? 3407 | invoke = mono_marshal_get_runtime_invoke_dynamic ();

Merge remote-tracking branch 'origin/main' into pr-emscripten-34-bump

1f0048f

Merge remote-tracking branch 'remotes/origin/main' into pr-emscripten…

17c0117

…-34-bump

Add emcc-link.rsp to PlatformManifestFileEntry

11e2ce5

Feedback

3eb44cf

https://github.com/emscripten-core/emscripten/blob/2fda25eea756c78c8cb024aa5b6c2b188bf7990f/src/settings.js#L1173-L1176 -s EXPORT_ES6 is link option

Merge remote-tracking branch 'remotes/origin/main' into pr-emscripten…

c0e4d84

…-34-bump

Bump emscripten version

460d09a

Bump llvm package version and use its libclang

6f7d0c2

Merge remote-tracking branch 'remotes/origin/main' into pr-emscripten…

b9c7488

…-34-bump

Use newer docker images with emscripten 3.1.1

e089ab1

Merge remote-tracking branch 'remotes/origin/main' into pr-emscripten…

1cfd8bb

…-34-bump

Remove unused variable

01c9516

Merge remote-tracking branch 'upstream/main' into wasm-threaded-build

ccbf541

Add runtime support for threads in the wasm build

731818a

To enable, pass `/p:WasmEnableThreads` when building the runtime ./build.sh -Subset mono+libs -os Browser -arch wasm /p:WasmEnableThreads=true

Prevent runtime from starting twice when loaded in a web worker

7142965

Automatically populate the emscripten mainScriptUrlOrBlob property so…

f83f093

… that worker initialization can find dotnet.js

Add compatibility shim so that emscripten's generated worker.js can p…

01cbb8d

…roperly get a Module instance, since we broke the API

Checkpoint

e7162e7

Bring back threadpool and add some tracing in diagnostics

7380334

Add comments and fix a typo

3121ca5

Introduce 'MonoObjectRef' ts type. Migrate mono_string_intern to not …

2cd8459

…have a retval

Checkpoint (strings are broken for some reason)

e483d20

Fix string interning

1bff860

Checkpoint

29ae4f7

lambdageek requested review from lateralusX, thaystg, marek-safar and MichalStrehovsky as code owners April 25, 2022 16:04

lambdageek mentioned this pull request Apr 25, 2022

[tracking] Experimental WebAssembly multithreading support #68162

Open

40 tasks

lambdageek added 6 commits April 25, 2022 12:20

Merge remote-tracking branch 'origin/main' into wasm-threading-eventpipe

de94606

merge followup: nullable is enabled by default now

edbb341

make eslint happy

96e8f2f

include wasm-config.h in wasm runtime host

1f2eda0

add wasm-config.h directory to includde directories

d44167c

include wasm-config.h into the runtime pack

abf8335

fixes aot compilation

steveisok approved these changes Apr 25, 2022

View reviewed changes

Add wasm-config.h to manifest

98467bf

ViktorHofer approved these changes Apr 25, 2022

View reviewed changes

put wasm-config.h into include/wasm from the outset

051356d

put back noExitRuntime replacement for CJS

71c9c6f

lateralusX approved these changes Apr 26, 2022

View reviewed changes

lambdageek merged commit b44c008 into dotnet:main Apr 26, 2022

akoeplinger reviewed Apr 26, 2022

View reviewed changes

lambdageek mentioned this pull request Apr 26, 2022

[System.Threading.Thread] Follow code style #68551

Closed

ghost locked as resolved and limited conversation to collaborators May 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[mono] merge wasm-threading-eventpipe into main #68232

[mono] merge wasm-threading-eventpipe into main #68232

lambdageek commented Apr 19, 2022 •

edited

Loading

steveisok left a comment

lambdageek commented Apr 25, 2022

azure-pipelines bot commented Apr 25, 2022

ViktorHofer left a comment

lambdageek commented Apr 25, 2022

azure-pipelines bot commented Apr 25, 2022

lambdageek commented Apr 26, 2022

azure-pipelines bot commented Apr 26, 2022

lateralusX left a comment

lateralusX Apr 26, 2022

lambdageek Apr 26, 2022 •

edited

Loading

lateralusX Apr 26, 2022

lambdageek Apr 26, 2022

akoeplinger left a comment

akoeplinger Apr 26, 2022

lambdageek Apr 26, 2022

lewing commented Apr 26, 2022


		## Building ##

		Build with `/p:WasmEnableThreads=true` to enable support for multi-threading.

[mono] merge wasm-threading-eventpipe into main #68232

[mono] merge wasm-threading-eventpipe into main #68232

Conversation

lambdageek commented Apr 19, 2022 • edited Loading

steveisok left a comment

Choose a reason for hiding this comment

lambdageek commented Apr 25, 2022

azure-pipelines bot commented Apr 25, 2022

ViktorHofer left a comment

Choose a reason for hiding this comment

lambdageek commented Apr 25, 2022

azure-pipelines bot commented Apr 25, 2022

lambdageek commented Apr 26, 2022

azure-pipelines bot commented Apr 26, 2022

lateralusX left a comment

Choose a reason for hiding this comment

lateralusX Apr 26, 2022

Choose a reason for hiding this comment

lambdageek Apr 26, 2022 • edited Loading

Choose a reason for hiding this comment

lateralusX Apr 26, 2022

Choose a reason for hiding this comment

lambdageek Apr 26, 2022

Choose a reason for hiding this comment

akoeplinger left a comment

Choose a reason for hiding this comment

akoeplinger Apr 26, 2022

Choose a reason for hiding this comment

lambdageek Apr 26, 2022

Choose a reason for hiding this comment

lewing commented Apr 26, 2022

lambdageek commented Apr 19, 2022 •

edited

Loading

lambdageek Apr 26, 2022 •

edited

Loading