Fix potential stack overflow in StdInReader #68398

vcsjones · 2022-04-22T16:39:41Z

ghost · 2022-04-22T16:39:48Z

Tagging subscribers to this area: @dotnet/area-system-console
See info in area-owners.md if you want to be subscribed.

Issue Details

src/libraries/System.Console/src/System/IO/StdInReader.cs

Co-authored-by: Theodore Tsirpanis <teo@tsirpanis.gr>

src/libraries/System.Console/src/System/IO/StdInReader.cs

danmoseley · 2022-04-23T17:25:52Z

Fix potential stack overflow

faef7d9

dotnet-issue-labeler bot added the area-System.Console label Apr 22, 2022

ghost assigned vcsjones Apr 22, 2022

vcsjones commented Apr 22, 2022

View reviewed changes

src/libraries/System.Console/src/System/IO/StdInReader.cs Outdated Show resolved Hide resolved

Reduce the size of the stack allocation

055ecba

teo-tsirpanis reviewed Apr 22, 2022

View reviewed changes

src/libraries/System.Console/src/System/IO/StdInReader.cs Outdated Show resolved Hide resolved

vcsjones and others added 2 commits April 22, 2022 18:26

Update src/libraries/System.Console/src/System/IO/StdInReader.cs

1a7d3db

Co-authored-by: Theodore Tsirpanis <teo@tsirpanis.gr>

Fix range check

f7f82dc

danmoseley reviewed Apr 22, 2022

View reviewed changes

src/libraries/System.Console/src/System/IO/StdInReader.cs Show resolved Hide resolved

danmoseley approved these changes Apr 22, 2022

View reviewed changes

danmoseley merged commit 10ac54d into dotnet:main Apr 23, 2022

adamsitnik added this to the 7.0.0 milestone Apr 26, 2022

ghost locked as resolved and limited conversation to collaborators May 26, 2022

vcsjones deleted the fix-68395 branch August 5, 2022 16:01

Provide feedback