Delete CLS_VAR
#68524
Merged
Delete CLS_VAR
#68524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ApplySelectorsTypeCheck already adds the cast in case it is necessary, and VN does support small-typed operands.
ghost
added
the
community-contribution
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsTODO: description.
|
SingleAccretion
force-pushed
the
Delete-ClsVar-Final
branch
from
6dbc72e
to
f292aff
Compare
|
@dotnet/jit-contrib |
SingleAccretion
commented
Apr 26, 2022
| @@ -8742,7 +8654,17 @@ void Compiler::fgValueNumberTree(GenTree* tree) | |||
| } | |||
| else if (isVolatile) | |||
| { | |||
| // For Volatile indirection, mutate GcHeap/ByrefExposed | |||
| // We just mutate GcHeap/ByrefExposed if isVolatile is true, and then do the read as normal. | |||
There was a problem hiding this comment.
The comment is unfortunately not quite correct anymore, we don't actually do "read as normal" on this path; I will adjust it in the future VN changes (it is a very nice comment overall).
jakobbotsch
approved these changes
Apr 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The final change in the
CLS_VARdeletion story. With this, we will now have a regular shape for "simple" static fields on all platforms, simplifying the IR and ensuring unified handling.We have some (overall positive) code diffs:
We also have some TP diffs, positive on all platforms but ARM itself, where we see a 0.1%-0.3% regression (presumably due to the enlarged IR). I think that's ok - the improvements made in #68383 should make the overall diff small.
SPMI in CI.