Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/linker #68547

Merged
merged 3 commits into from
Apr 28, 2022

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Apr 26, 2022

This pull request updates the following dependencies

From https://github.com/dotnet/linker

  • Subscription: 0d6d6ae4-f71f-4395-53e6-08d8e409d87d
  • Build: 20220426.3
  • Date Produced: April 26, 2022 11:14:09 PM UTC
  • Commit: 6ffb647f615c9ae18e3af4ccf075e83c27855ef5
  • Branch: refs/heads/main

…425.3

Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-1.22222.1 -> To Version 7.0.100-1.22225.3
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow label Apr 26, 2022
…426.3

Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-1.22222.1 -> To Version 7.0.100-1.22226.3
@tlakollo
Copy link
Contributor

After merging dotnet/linker#2758 we now have support to analyze calls to MakeGenericType/MakeGenericMethod/Expression.Call in the analyzer. This change generates a new warning in System.Runtime.Serialization.ClassDataContract, although the warning is valid we believed that it wasn't being generated before by the Trimmer because the UnadaptedClassType is dead code and Trimmer stripped out that code not generating a warning.

@tlakollo tlakollo self-assigned this Apr 27, 2022
@tlakollo tlakollo requested a review from vitek-karas April 27, 2022 19:37
@vitek-karas
Copy link
Member

The change to remove the dead code looks good to me.

Copy link
Member

@StephenMolloy StephenMolloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@tlakollo
Copy link
Contributor

The maestro auto-merge check is failing because there hasn't been a successful build since yesterday at 7:55 PM. It's unrelated to the changes in this PR since its also failing in other PRs.

@tlakollo tlakollo merged commit a926355 into main Apr 28, 2022
@tlakollo tlakollo deleted the darc-main-b26170db-0af5-4f90-8672-753147b638eb branch April 28, 2022 04:01
@ghost ghost locked as resolved and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-codeflow for labeling automated codeflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants