Reenable 4244

[AaronRobinsonMSFT]

This reenables 4244 in all places other than mono/

Contributes to #66154

I broke down the updates by general area.

@Maoni0 @PeterSolMS See the GC commit
@janvorli There is a single exception walk logic update. See the Debugger commit
@BruceForstall There is a single SuperPMI update - See the SuperPMI commit

@jkotas @davidwrighton @elinor-fung Eyes on the rest are most welcome.

@am11 @janvorli I updated zlib-intel. Is there an upstream I can create a PR for?

[ghost]

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

---

This reenables 4244 in all places other than mono/

Contributes to #66154

I broke down the updates by general area.

@Maoni0 @PeterSolMS See the GC commit
@janvorli There is a single exception walk logic update. See the Debugger commit
@BruceForstall There is a single SuperPMI update - See the SuperPMI commit

@jkotas @davidwrighton @elinor-fung Eyes on the rest are most welcome.

@am11 @janvorli I updated zlib-intel. Is there an upstream I can create a PR for?

Author:	AaronRobinsonMSFT
Assignees:	-
Labels:	area-Infrastructure-coreclr
Milestone:	7.0.0

[am11]

@am11 @janvorli I updated zlib-intel. Is there an upstream I can create a PR for?

Upstream info of external libs are in their version files:

runtime/src/native/external/zlib-intel-version.txt

Line 3 in 694067c

https://github.com/jtkukunas/zlib/commit/bf103c626c6c0d80580748f6b814ec534614ca52

Note that @lambdageek is in the process of updating zlib and zlib-intel: #68219.

[AaronRobinsonMSFT]

@am11 and @janvorli I've updated the cmake files for zlib and zlib-intel to suppress 4244. This will likely need to be discussed with @GrabYourPitchforks at some point.

[BruceForstall]

The (new) SuperPMI change LGTM.

[BruceForstall]

@TIHan PTAL at ilasm changes

[hoyosjs]

Changes under src/coreclr/debug lgtm

[AaronRobinsonMSFT]

@dotnet/runtime-infrastructure Any thoughts on why the above libraries test leg keeps timing out? I'm trying to investigate but I've not found a clear way to get at a root cause.

[elinor-fung]

@AaronRobinsonMSFT if you look at the 'Tests' page, you can see all the files from the failed tests / work items. For example, Common.Tests has runclient.py with:

2022-04-28T03:05:08.214Z	ERROR  	dockerhelper(234)	run	API Error attempting to talk to Docker Server:500 Server Error: Internal Server Error ("CreateComputeSystem b383d37b60e2cd59ad9126c53bb7e6946dc7f782171e4def1f060da2658f1555: The request is not supported.
(extra info: {"SystemType":"Container","Name":"b383d37b60e2cd59ad9126c53bb7e6946dc7f782171e4def1f060da2658f1555","Owner":"docker","IgnoreFlushesDuringBoot":true,"LayerFolderPath":"C:\\ProgramData\\docker\\windowsfilter\\b383d37b60e2cd59ad9126c53bb7e6946dc7f782171e4def1f060da2658f1555","Layers":[{"ID":"db134083-cd0b-536f-93e9-0af42a5ff824","Path":"C:\\ProgramData\\docker\\windowsfilter\\2ee0ad8716a2921b6ec97f3e17501719d02f65bf11557f7197498baa67b2b3ca"},{"ID":"808dfe38-0ccf-56dc-bdf6-a627d53c9317","Path":"C:\\ProgramData\\docker\\windowsfilter\\26d91aa8bd91c232381bd04b8874b423e8f003755e7f7a7b24c44e7fce4b5175"},{"ID":"70f128ad-f002-5da8-bdfb-bbf12baf23dd","Path":"C:\\ProgramData\\docker\\windowsfilter\\c92ef09ee95ce4d23634516e8191325434bbd08c61052272b16bb7974e80ddd2"},{"ID":"49aa4bf6-9b6f-5f50-aeee-5103edea52e5","Path":"C:\\ProgramData\\docker\\windowsfilter\\4abc5e659674f9b859f48f5410e9835afe3f8ca179f4a5729df811f22e8448f1"},{"ID":"0816a465-a1d8-5d37-9b58-3e4602789def","Path":"C:\\ProgramData\\docker\\windowsfilter\\591e6d4e153a9d176607c1551d3786ed16b537a7d75782b2ab7439c4fe69e4cd"},{"ID":"c26a40cf-448a-592c-865a-5a5d507bdba0","Path":"C:\\ProgramData\\docker\\windowsfilter\\a3297886af2dcba3a7821313e48311c305f669a735aea89ff457ef4366690f5d"},{"ID":"846b7ba4-13e7-5ea0-9608-45e4e7d002e7","Path":"C:\\ProgramData\\docker\\windowsfilter\\280bc58919b8e4bcf5945a59f50ea44f937868e32341f0971c3e8163a362c3f3"},{"ID":"620aa9ec-4288-524b-8a0a-109b0faa986c","Path":"C:\\ProgramData\\docker\\windowsfilter\\f2238c95c93b75378e9a3f0a25e9386435eb755871e73e6b1a3b77c86ffa2991"},{"ID":"e36d97d8-7c80-5a7f-84e8-cfef2cb347d6","Path":"C:\\ProgramData\\docker\\windowsfilter\\98dc643936ef9cb43c3a1304a4365ba5fd28e9c4c679e0b6aaf991ded23dd259"},{"ID":"493e577b-9bf4-5a4a-8681-20c4ec9856fa","Path":"C:\\ProgramData\\docker\\windowsfilter\\0ba331a13d97d11d558b3ed6dd68800f0a4d9c581cd0bb846ef47525d87b9647"},{"ID":"c1510d08-b250-5ad8-bfc7-7e18358e4682","Path":"C:\\ProgramData\\docker\\windowsfilter\\61e7b6f5d4008c9716d209a7f5ad2f72785b43b41270564c0d97463738fa014d"},{"ID":"d6ccf007-562e-5c76-9c21-180a8152a023","Path":"C:\\ProgramData\\docker\\windowsfilter\\0b87d575ed0c070d7a2342db9d85094a5449c8c0a0152e7056a030c1aef4f6e5"},{"ID":"b6b85aad-edb2-505e-8c2c-95e62a78bb43","Path":"C:\\ProgramData\\docker\\windowsfilter\\65f7f5c897d951a2e4b118c6604a35349e8e391419f0c4f3ad91a7524ddf7df7"},{"ID":"2cbbe230-b5c8-5b95-b785-aab1f1bb3756","Path":"C:\\ProgramData\\docker\\windowsfilter\\acf0278e56a7b176f493ed7929d4e778ebe0ebf1d713db873b76313147d4b45c"},{"ID":"8f3635b4-4d75-51a5-aaec-b85b74c5e115","Path":"C:\\ProgramData\\docker\\windowsfilter\\c5f8e965124427ad811acd3a3eef43745603f149ca170e268baf6d451f9f56cd"},{"ID":"8f2d03b8-e1ea-5456-817d-2979f7181836","Path":"C:\\ProgramData\\docker\\windowsfilter\\fc41f5531dd809a5f07bb6d7f05ae8c6dcc57c557001d87a6e61a661ec02ec35"},{"ID":"4edb3e43-f9f2-5cac-b03e-c15330737aa5","Path":"C:\\ProgramData\\docker\\windowsfilter\\d7f96fc94622a66dc6bba0ba93ffe93b22fecff1d8ec07de91c54523aac60251"},{"ID":"a416aa90-186a-5dc7-a760-e43ed52645c8","Path":"C:\\ProgramData\\docker\\windowsfilter\\867b010d482f5e62a8c7d6651f3a081e5fc89a5fdc12b340d6c75d32cb8d8f3f"}],"HostName":"Da006Z07","MappedDirectories":[{"HostPath":"c:\\users\\runner\\appdata\\local\\temp\\e1c4846095494419af4056bf299fd710","ContainerPath":"c:\\commands","ReadOnly":true,"BandwidthMaximum":0,"IOPSMaximum":0,"CreateInUtilityVM":false},{"HostPath":"c:\\h\\scripts\\helix-scripts-no-deps","ContainerPath":"c:\\helix\\scripts","ReadOnly":true,"BandwidthMaximum":0,"IOPSMaximum":0,"CreateInUtilityVM":false},{"HostPath":"c:\\h\\logs","ContainerPath":"c:\\helix\\logs","ReadOnly":false,"BandwidthMaximum":0,"IOPSMaximum":0,"CreateInUtilityVM":false},{"HostPath":"c:\\cores","ContainerPath":"c:\\helix\\cores","ReadOnly":false,"BandwidthMaximum":0,"IOPSMaximum":0,"CreateInUtilityVM":false},{"HostPath":"c:\\h\\config","ContainerPath":"c:\\helix\\config","ReadOnly":true,"BandwidthMaximum":0,"IOPSMaximum":0,"CreateInUtilityVM":false},{"HostPath":"c:\\h\\w\\acdd08c1\\p","ContainerPath":"c:\\helix\\work\\correlation","ReadOnly":true,"BandwidthMaximum":0,"IOPSMaximum":0,"CreateInUtilityVM":false},{"HostPath":"c:\\h\\w\\acdd08c1\\w\\af2d0968\\u","ContainerPath":"c:\\helix\\work\\workitem\\u","ReadOnly":false,"BandwidthMaximum":0,"IOPSMaximum":0,"CreateInUtilityVM":false},{"HostPath":"c:\\h\\w\\acdd08c1\\w\\af2d0968\\e","ContainerPath":"c:\\helix\\work\\workitem\\e","ReadOnly":false,"BandwidthMaximum":0,"IOPSMaximum":0,"CreateInUtilityVM":false},{"HostPath":"c:\\h\\w\\acdd08c1\\w\\af2d0968\\uploads","ContainerPath":"c:\\helix\\work\\workitem\\uploads","ReadOnly":false,"BandwidthMaximum":0,"IOPSMaximum":0,"CreateInUtilityVM":false}],"HvPartition":true,"EndpointList":["6A5B32C4-A310-414C-A37D-79BD2BD551D5"],"HvRuntime":{"ImagePath":"C:\\ProgramData\\docker\\windowsfilter\\d7f96fc94622a66dc6bba0ba93ffe93b22fecff1d8ec07de91c54523aac60251\\UtilityVM"},"AllowUnqualifiedDNSQuery":true})")
2022-04-28T03:05:08.218Z	ERROR  	dockerhelper(235)	run	Docker may not be configured correctly on this machine.  Contact dnceng for help.

[AaronRobinsonMSFT]

@elinor-fung Thanks. The following doesn't seem like it is anything I've done:

API Error attempting to talk to Docker Server:500 Server Error: Internal Server Error ("CreateComputeSystem b383d37b60e2cd59ad9126c53bb7e6946dc7f782171e4def1f060da2658f1555: The request is not supported.

[AaronRobinsonMSFT]

The timeout/failure above is tracked in #67728.

[AaronRobinsonMSFT]

@jkotas @Maoni0 @PeterSolMS @elinor-fung @TIHan Can you please take another look at this?

This would finish off the current SDL requirements for the repo outside of src/mono.

[jkotas]

LGTM otherwise

[AaronRobinsonMSFT]

This seems to be a failure with uploading logs. The tests appear to have all passed.

/cc @dotnet/runtime-infrastructure

Starting: Publish SuperPMI logs
==============================================================================
Task         : Publish Pipeline Artifacts
Description  : Publish (upload) a file or directory as a named artifact for the current run
Version      : 1.199.0
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/publish-pipeline-artifact
==============================================================================
Artifact name input: SuperPMI_Logs_x64_checked
Uploading pipeline artifact from D:\a\_work\1\s\artifacts\spmi_logs\ for build #1751868
Using default max parallelism.
Max dedup parallelism: 192
ApplicationInsightsTelemetrySender will correlate events with X-TFS-Session 99b3589b-74bb-4465-8404-9d202c2e4a5b
DedupManifestArtifactClient will correlate http requests with X-TFS-Session 99b3589b-74bb-4465-8404-9d202c2e4a5b
10 files processed.
Processed 10 files from D:\a\_work\1\s\artifacts\spmi_logs\ successfully.
Uploaded 245,954 out of 245,954 bytes
Content upload is done!

Content upload statistics:
Total Content: 0.5 MB
Physical Content Uploaded: 25.8 KB
Logical Content Uploaded: 0.2 MB
Compression Saved: 0.2 MB
Deduplication Saved: 0.2 MB
Number of Chunks Uploaded: 11
Total Number of Chunks: 21

ApplicationInsightsTelemetrySender correlated 2 events with X-TFS-Session 99b3589b-74bb-4465-8404-9d202c2e4a5b
##[error]Artifact SuperPMI_Logs_x64_checked already exists for build 1751868.
Finishing: Publish SuperPMI logs

Starting: Publish SuperPMI build logs
==============================================================================
Task         : Publish Pipeline Artifacts
Description  : Publish (upload) a file or directory as a named artifact for the current run
Version      : 1.199.0
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/publish-pipeline-artifact
==============================================================================
Artifact name input: SuperPMI_BuildLogs_x64_checked
Uploading pipeline artifact from D:\a\_work\1\s\artifacts\log for build #1751868
Using default max parallelism.
Max dedup parallelism: 192
ApplicationInsightsTelemetrySender will correlate events with X-TFS-Session 55a4c631-7e5b-442b-a442-7a8a42f76f37
DedupManifestArtifactClient will correlate http requests with X-TFS-Session 55a4c631-7e5b-442b-a442-7a8a42f76f37
3 files processed.
Processed 3 files from D:\a\_work\1\s\artifacts\log successfully.
Uploaded 538,189 out of 597,510 bytes
Content upload is done!

Content upload statistics:
Total Content: 1.2 MB
Physical Content Uploaded: 0.5 MB
Logical Content Uploaded: 0.5 MB
Compression Saved: 57.0 bytes
Deduplication Saved: 0.7 MB
Number of Chunks Uploaded: 9
Total Number of Chunks: 27

ApplicationInsightsTelemetrySender correlated 2 events with X-TFS-Session 55a4c631-7e5b-442b-a442-7a8a42f76f37
##[error]Artifact SuperPMI_BuildLogs_x64_checked already exists for build 1751868.
Finishing: Publish SuperPMI build logs