Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fixed and Sliding Window RateLimiters + PartitionedRateLimiter.Create #68695

Merged
merged 2 commits into from
Apr 29, 2022

Conversation

BrennanConroy
Copy link
Member

Backport of #67677 and #68087 to release/7.0-preview4

Customer Impact

We added new APIs for Sliding Window and Fixed Window rate limiters as well as PartitionedRateLimiter.Create for the default experience of creating a PartitionedRateLimiter.

We would love to start getting customer feedback on these core APIs. As well as make the new Rate Limiting Middleware in ASP.NET Core that is shipping in preview4 easier to use, which the PartitionedRateLimiter.Create API helps with.

Testing

There is a good base set of test cases that are common among all the rate limiter implementations. As well as a suite of new tests for the PartitionedRateLimiter.

Risk

Low. These APIs are in their own new assembly and shipped as standalone packages today. No other area in Runtime currently use them and the APIs used by ASP.NET Core were not modified.

@BrennanConroy BrennanConroy added Servicing-consider Issue for next servicing release review area-System.Threading labels Apr 29, 2022
@BrennanConroy BrennanConroy added this to the 7.0.0 milestone Apr 29, 2022
@ghost ghost assigned BrennanConroy Apr 29, 2022
@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Apr 29, 2022

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #67677 and #68087 to release/7.0-preview4

Customer Impact

We added new APIs for Sliding Window and Fixed Window rate limiters as well as PartitionedRateLimiter.Create for the default experience of creating a PartitionedRateLimiter.

We would love to start getting customer feedback on these core APIs. As well as make the new Rate Limiting Middleware in ASP.NET Core that is shipping in preview4 easier to use, which the PartitionedRateLimiter.Create API helps with.

Testing

There is a good base set of test cases that are common among all the rate limiter implementations. As well as a suite of new tests for the PartitionedRateLimiter.

Risk

Low. These APIs are in their own new assembly and shipped as standalone packages today. No other area in Runtime currently use them and the APIs used by ASP.NET Core were not modified.

Author: BrennanConroy
Assignees: -
Labels:

Servicing-consider, area-System.Threading

Milestone: 7.0.0

@BrennanConroy BrennanConroy added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Apr 29, 2022
@BrennanConroy
Copy link
Member Author

Preview4 approved over email.

@carlossanlop
Copy link
Member

Unelated test failure coming from System.IO.Compression.Tests.ZipFile_Unix.UnixCreateSetsPermissionsInExternalAttributes was disabled a week ago in main, but not in the release/7.0-preview4 branch: #68293

@BrennanConroy
Copy link
Member Author

@carlossanlop Are you able to merge?

@mmitche mmitche merged commit 9c37a3b into dotnet:release/7.0-preview4 Apr 29, 2022
@BrennanConroy BrennanConroy deleted the brecon/bpRL branch April 29, 2022 19:25
@ghost ghost locked as resolved and limited conversation to collaborators May 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants