-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Fixed and Sliding Window RateLimiters + PartitionedRateLimiter.Create #68695
Add Fixed and Sliding Window RateLimiters + PartitionedRateLimiter.Create #68695
Conversation
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
Tagging subscribers to this area: @mangod9 Issue DetailsBackport of #67677 and #68087 to release/7.0-preview4 Customer ImpactWe added new APIs for Sliding Window and Fixed Window rate limiters as well as We would love to start getting customer feedback on these core APIs. As well as make the new Rate Limiting Middleware in ASP.NET Core that is shipping in preview4 easier to use, which the TestingThere is a good base set of test cases that are common among all the rate limiter implementations. As well as a suite of new tests for the RiskLow. These APIs are in their own new assembly and shipped as standalone packages today. No other area in Runtime currently use them and the APIs used by ASP.NET Core were not modified.
|
b8f9399
to
aa07ac0
Compare
Preview4 approved over email. |
Unelated test failure coming from |
@carlossanlop Are you able to merge? |
Backport of #67677 and #68087 to release/7.0-preview4
Customer Impact
We added new APIs for Sliding Window and Fixed Window rate limiters as well as
PartitionedRateLimiter.Create
for the default experience of creating aPartitionedRateLimiter
.We would love to start getting customer feedback on these core APIs. As well as make the new Rate Limiting Middleware in ASP.NET Core that is shipping in preview4 easier to use, which the
PartitionedRateLimiter.Create
API helps with.Testing
There is a good base set of test cases that are common among all the rate limiter implementations. As well as a suite of new tests for the
PartitionedRateLimiter
.Risk
Low. These APIs are in their own new assembly and shipped as standalone packages today. No other area in Runtime currently use them and the APIs used by ASP.NET Core were not modified.