Replace invalid sourcegen debug assertion with runtime check #68828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsPer #68072, Roslyn's Fix #68072.
|
This reverts commit 5247c1f.
krwq
reviewed
May 4, 2022
src/libraries/System.Text.Json/gen/Reflection/CustomAttributeDataWrapper.cs
Show resolved
Hide resolved
krwq
approved these changes
May 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #68072, Roslyn's
AttributeData.AttributeConstructorproperty can returnnullif generating source for unresolved symbols. The STJ source generator erroneously asserts that the constructor can never be null, resulting in assert failure popups when working with debug builds of the source generator. This PR replaces the debug assertion with a runtime check (in line with how we throw exceptions in other parts of the source generator).Fix #68072.