-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Docker images from mcr.microsoft.com in EnterpriseTests #68875
Conversation
We started getting warnings in the build about using images from docker directly, see https://docs.opensource.microsoft.com/tools/nuget_security_analysis/container_registry_analysis/ The image from dotnet-buildtools-prereqs-docker can be used instead.
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Tagging subscribers to this area: @dotnet/ncl, @vcsjones Issue DetailsWe started getting warnings in the build about using images from docker directly, see https://docs.opensource.microsoft.com/tools/nuget_security_analysis/container_registry_analysis/ The image from dotnet-buildtools-prereqs-docker can be used instead.
|
@@ -1,4 +1,4 @@ | |||
FROM ubuntu:18.04 | |||
FROM mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-18.04-20220421022739-9c434db |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there no mcr version of ubuntu with the floating tag? Or is there a better image to use that rolls in any of the vetted registries?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, there isn't a floating version on mcr. we're already using this image in a couple other places in the build.
Can you run the enterprise pipeline on this @MattGal? It would be nice not to make changes while the pipeline is disabled. |
/azp run runtime-libraries enterprise-linux |
Azure Pipelines successfully started running 1 pipeline(s). |
https://dev.azure.com/dnceng/public/_build/results?buildId=1753553&view=ms.vss-test-web.build-test-results-tab has the same test failure as the last PR build of the enterprise pipeline so should be fine. Merging to get rid of the warnings. |
…8875) We started getting warnings in the build about using images from docker directly, see https://docs.opensource.microsoft.com/tools/nuget_security_analysis/container_registry_analysis/ The image from dotnet-buildtools-prereqs-docker can be used instead. (cherry picked from commit bafae1b)
…68913) * attempt to fix up EnterpriseTests (#65981) * attemp to fix up EnterpriseTests * fix text * increase timoeout on build step * fix temeout * add jobs * update job * fix formating * fix name * update server check * restore original resolver before tests * fix path * experiment (cherry picked from commit 9174037) * upgrade docker to get clang9 to prevent coreclr crashes (#68311) (cherry picked from commit edb9c49) * Use Docker images from mcr.microsoft.com in EnterpriseTests (#68875) We started getting warnings in the build about using images from docker directly, see https://docs.opensource.microsoft.com/tools/nuget_security_analysis/container_registry_analysis/ The image from dotnet-buildtools-prereqs-docker can be used instead. (cherry picked from commit bafae1b) Co-authored-by: Tomas Weinfurt <tweinfurt@yahoo.com>
We started getting warnings in the build about using images from docker directly, see https://docs.opensource.microsoft.com/tools/nuget_security_analysis/container_registry_analysis/
The image from dotnet-buildtools-prereqs-docker can be used instead.