Support Requires on type in NativeAot #68978
Conversation
- Adds new overload for MessageOrigin creation that uses MethodIL and an offset as parameters, eventually this will be used to produce warnings - Share methods used in linker/analyzer for asking questions about members being in RequiresScope, members Requiring and Requires warning generation. These methods include handling of Requires on a type. - The ReflectionMethodBodyScanner on field access now verifies for requires on type, since implicitly can call the static constructor - Updated the mismatch attribute rules to take into account Requires on type
| /// <remarks>Unlike <see cref="DoesMethodRequires(MethodDesc, string, out CustomAttributeValue?)"/> | ||
| /// if a declaring type has Requires, all methods in that type are considered "in scope" of that Requires. So this includes also | ||
| /// instance methods (not just statics and .ctors).</remarks> | ||
| internal static bool IsMethodInRequiresScope(this MethodDesc method, string requiresAttribute) |
There was a problem hiding this comment.
I would call this IsInRequiresScope - that's the name we use in the analyzer - so it will be easier to lookup the matching functionality there. (The body does match the behavior, so the name might as well)
There was a problem hiding this comment.
I see the linker calls this IsMethodInRequiresUnreferencedCodeScope...
In that case I don't mind the current name, but we should then rename the one in the analyzer to match.
And please add a comment which methods this is a counterpart for.
There was a problem hiding this comment.
Opened dotnet/linker#2788 to track the changes between linker/analyzer
src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/Dataflow/DiagnosticUtilities.cs
Outdated
Show resolved
Hide resolved
src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/Dataflow/ReflectionMethodBodyScanner.cs
Outdated
Show resolved
Hide resolved
src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/Dataflow/ReflectionMethodBodyScanner.cs
Outdated
Show resolved
Hide resolved
|
In an offline discussion, we discussed that his PR should also take into account that PublishAot implies that the app will be trimmed and single file. Meaning that NativeAOT compiler should produce warnings about single file too. Also, if PublishAot is set that also means that EnableAotAnalyzer, EnableTrimAnalyzer and EnableSingleFileAnalyzer should be set too. See dotnet/sdk#25301 |
Added support for RequiresAssemblyFilesAttribute - Now the code checks for RAF and warns about it - Added support to check and retrieve attributes in a property - Added overloads to IsInRequiresScope that verify associated properties Added new constant values for the different requires attributes
src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/Dataflow/DiagnosticUtilities.cs
Outdated
Show resolved
Hide resolved
Add static constructor id Change this name in GetDecodedCustomAttribute for prop
ghost
locked as resolved and limited conversation to collaborators
Support Requires on type in NativeAot