Workaround crash in Microsoft.DiaSymReader.Native #68990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @tommcdon Issue DetailsIssue: #59077 The fix is to check if the module has a portable PDB in the debug directory Add support for in-memory embedded PDBs.
|
mikem8361
force-pushed
the
diasymreader
branch
2 times, most recently
from
db67a21 to
f3b9e0f
Compare
Issue: dotnet#59077 The fix is to check if the module has a portable PDB in the debug directory and use the well-tested managed portable PDB source/line number code. Add support for in-memory embedded PDBs.
|
Can I get a review? Thanks. |
hoyosjs
approved these changes
May 16, 2022
noahfalk
approved these changes
May 16, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #59077
The fix is to check if the module has a portable PDB in the debug directory
and use the well-tested managed portable PDB source/line number code.
Add support for in-memory embedded PDBs.