-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add markdown Readme for System.Text.Json #69015
Conversation
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsI've decided to submit a PR for one of the popular packages to see how it would go. Related to #59630
|
Is If we do add a README.md to the System.Text.Json, I think it might be preferable if it contained resources specific to developing/contributing to the library, e.g. STJ-specific instructions on coding conventions, testing, etc. that might somehow deviate from the repo-wide dev workflow guide. |
I think it's useful to have embedded markdown readme, mainly to help users who come from search engines into Nuget package page understand what's this package for and how to use it. Note that there's already mini-documentation in plaintext embedded into .csproj (PackageDescription); this change enables to use Markdown so it could contain links and formatting. I can remove example if it's too hard to maintain it. I was thinking it's good to add quick usage example on package page, that helps to start using library.
The main point of this is to display the readme on Nuget gallery page, it should be user-oriented doc. Including contributor-oriented docs would be against the intended purpose. Well, such docs could also be added into the repo, but they don't need to be embedded into package. |
If it's meant to function as a token code sample, then it probably won't require maintenance. But if it's just a token code sample, arguably a link to the up-to-date documentation is more valuable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in principle, although I'd just remove the Example & Commonly Used Types sections. With the library constantly evolving (e.g. inclusion of sourcegen last year) I think it will be difficult to keep up-to-date. The link to the docs should provide relevant context.
cc @danmoseley @carlossanlop regarding embedding documenting directly into our packages. |
Co-authored-by: Eirik Tsarpalis <eirik.tsarpalis@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Co-authored-by: Eirik Tsarpalis <eirik.tsarpalis@gmail.com> Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
Many thanks @MSDN-WhiteKnight 👍 |
I've decided to submit a PR for one of the popular packages to see how it would go.
Related to #59630