ARM64 - Add GT_CHK_DIV_BY_ZERO #69170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsThis is currently a draft, but the hope is to add a specific node that represents the divide-by-zero check.
|
…handling the GT_CHK_DIV_BY_ZERO case in morph.
TIHan
commented
May 13, 2022
TIHan
commented
May 13, 2022
| @@ -10795,6 +10795,11 @@ void Compiler::fgValueNumberAddExceptionSet(GenTree* tree) | |||
| fgValueNumberAddExceptionSetForBoundsCheck(tree); | |||
| break; | |||
|
|
|||
| #ifdef TARGET_ARM64 | |||
| case GT_CHK_DIV_BY_ZERO: | |||
| break; | |||
There was a problem hiding this comment.
Will need to add an impl for the case here.
TIHan
commented
May 13, 2022
| @@ -5099,6 +5099,13 @@ unsigned Compiler::gtSetEvalOrder(GenTree* tree) | |||
| costSz = 7; // jump to cold section | |||
| break; | |||
|
|
|||
| #ifdef TARGET_ARM64 | |||
| case GT_CHK_DIV_BY_ZERO: | |||
| costEx = 4; | |||
There was a problem hiding this comment.
Not sure what the costs should be. I just copied from GT_BOUNDS_CHECK from above.
ghost
closed this
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
ghost
locked as resolved and limited conversation to collaborators
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently a draft, but the hope is to add a specific node that represents the divide-by-zero check.