Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NoTargets.SDK and remove unnecessary properties being set #69242

Merged
merged 8 commits into from
May 12, 2022

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented May 12, 2022

The NoTargets.SDK now already sets the DebugType and DebugSymbols properties to None/false (as NoTargets projects don't compile anything).

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost assigned ViktorHofer May 12, 2022
@ghost
Copy link

ghost commented May 12, 2022

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

The NoTargets.SDK now already sets the DebugType and DebugSymbols properties to None/false.

Author: ViktorHofer
Assignees: ViktorHofer
Labels:

area-Infrastructure

Milestone: -

@ViktorHofer
Copy link
Member Author

Failures are known and already tracked.

@ViktorHofer ViktorHofer merged commit 997d912 into main May 12, 2022
@ViktorHofer ViktorHofer deleted the ViktorHofer-patch-1 branch May 12, 2022 16:18
@ghost ghost locked as resolved and limited conversation to collaborators Jun 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants