Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run host tests with dotnet test and enable crash/hang dumps #69340

Merged
merged 5 commits into from
May 19, 2022
Merged

Run host tests with dotnet test and enable crash/hang dumps #69340

merged 5 commits into from
May 19, 2022

Conversation

elinor-fung
Copy link
Member

@elinor-fung elinor-fung commented May 14, 2022 •
edited
Loading

  • Switch host tests to run using dotnet test
  • Enable blame sequence, crash dumps, and hang dumps
    • These are uploaded during publish of test results as an attachment to the test run - example
  • Upload host binaries/symbols on failure so that they can be used to investigate any dumps - example

Related: #69114

@ghost ghost assigned elinor-fung May 14, 2022
@ghost
Copy link

ghost commented May 14, 2022

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: elinor-fung
Assignees: elinor-fung
Labels:

area-Host
Milestone: -

@elinor-fung elinor-fung force-pushed the hostTestDump branch 6 times, most recently from 45cabf4 to d761328 Compare May 16, 2022 18:36
@elinor-fung elinor-fung force-pushed the hostTestDump branch 3 times, most recently from 7d303ef to cc8966e Compare May 17, 2022 03:32
@elinor-fung elinor-fung marked this pull request as ready for review May 18, 2022 22:10
@elinor-fung elinor-fung requested review from vitek-karas and a team May 18, 2022 22:12
@elinor-fung elinor-fung merged commit 55090e6 into dotnet:main May 19, 2022
@elinor-fung elinor-fung deleted the hostTestDump branch May 19, 2022 02:02
@ViktorHofer
Copy link
Member

As I didn't see a change of the actual test runner invocation, does this use Arcade's dotnet test support?

@elinor-fung
Copy link
Member Author

Yes, it is using Arcade's support (via setting UseVSTestRunner).

@ghost ghost locked as resolved and limited conversation to collaborators Jun 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

@vitek-karas vitek-karas Awaiting requested review from vitek-karas

Assignees

@elinor-fung elinor-fung

Labels
area-Host
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elinor-fung @ViktorHofer @jkoritzinsky