Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CanCreateSymbolicLinks instead of IsSymLinkSupported #69592

Closed
wants to merge 2 commits into from
Closed

Use CanCreateSymbolicLinks instead of IsSymLinkSupported #69592

wants to merge 2 commits into from

Conversation

jozkee
Copy link
Member

@jozkee jozkee commented May 20, 2022

  • Remove redundant PlatformDetection.IsSymLinkSupported.
  • Move CanCreateSymbolicLinks to PlatformDetection (from MountHelper).
  • Change logic of CreateSymbolicLink to use our APIs for creation, when possible.

Fixes #69470.

@jozkee jozkee added this to the 7.0.0 milestone May 20, 2022
@jozkee jozkee self-assigned this May 20, 2022
@ghost
Copy link

ghost commented May 20, 2022

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Remove redundant PlatformDetection.IsSymLinkSupported.
  • Move CanCreateSymbolicLinks to PlatformDetection (from MountHelper).
  • Change logic of CreateSymbolicLink to use our APIs for creation, when possible.

Fixes #69470.

Author: Jozkee
Assignees: Jozkee
Labels:

area-System.IO
Milestone: 7.0.0

@jozkee
Copy link
Member Author

jozkee commented May 20, 2022

If we backport #69150 to .NET 6, we will need to port this as well, as the former triggers CI issues. Let me know if this PR is too cumbersome for backporting and I can rethink on how to make leaner changes to address #69470.

@jeffhandley
Copy link
Member

@jozkee I'm closing this PR as it's gotten stale and has conflicts. We can create a new PR when this gets revisited.

@ghost ghost locked as resolved and limited conversation to collaborators Jul 25, 2022
@jozkee jozkee deleted the platdetection_cancreatesymlinks branch April 16, 2024 16:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iSazonov iSazonov iSazonov left review comments

@carlossanlop carlossanlop Awaiting requested review from carlossanlop

@adamsitnik adamsitnik Awaiting requested review from adamsitnik

Assignees

@jozkee jozkee

Labels
area-System.IO
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

Microsoft.Extensions.FileProviders.PhysicalFileProviderTests failing when running libraries tests
3 participants
@jozkee @jeffhandley @iSazonov