Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up ValueType.Equals #69768

Merged
merged 1 commit into from
May 25, 2022
Merged

Speed up ValueType.Equals #69768

merged 1 commit into from
May 25, 2022

Conversation

MichalStrehovsky
Copy link
Member

Inspired by #69723

SpanHelpers didn't exist when this part of NativeAOT was written (dotnet/corert#5436 (comment)).

Inspired by #69723 

`SpanHelpers` didn't exist when this part of NativeAOT was written (dotnet/corert#5436 (comment)).
@MichalStrehovsky
Copy link
Member Author

@dotnet/ilc-contrib any opinion on notification for non-ILCompiler NativeAOT changes? Should we just use ilc-contrib, or add nativeaot-contrib for the libraries part? The libs and compiler part are often intertwined (the place I'm touching here is very close to the ValueType.__GetFieldHelper method that is part of a corelib+compiler protocol).

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jkotas
Copy link
Member

jkotas commented May 25, 2022

Should we just use ilc-contrib

I think so

@MichalStrehovsky MichalStrehovsky merged commit 0dba0ee into main May 25, 2022
@MichalStrehovsky MichalStrehovsky deleted the MichalStrehovsky-patch-2 branch May 25, 2022 03:58
@ghost ghost locked as resolved and limited conversation to collaborators Jun 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants