Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LoongArch64] Fix some errors for LA-ABI. #69771

Merged
merged 1 commit into from
May 25, 2022
Merged

[LoongArch64] Fix some errors for LA-ABI. #69771

merged 1 commit into from
May 25, 2022

Conversation

shushanhf
Copy link
Contributor

Fixed some errors for LA-ABI when running all the runtime's test cases.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label May 25, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 25, 2022
@ghost
Copy link

ghost commented May 25, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixed some errors for LA-ABI when running all the runtime's test cases.

Author: shushanhf
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution
Milestone: -

@shushanhf
Copy link
Contributor Author

This PR is part of the issus #69705

@shushanhf
Copy link
Contributor Author

Hi, @BruceForstall
Could you please review this PR ?

@BruceForstall BruceForstall self-requested a review May 25, 2022 17:26
BruceForstall
BruceForstall approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for continuing to update LA.

@BruceForstall BruceForstall merged commit e966420 into dotnet:main May 25, 2022
@shushanhf shushanhf deleted the main_LA-ABI branch May 26, 2022 01:12
@ghost ghost locked as resolved and limited conversation to collaborators Jun 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BruceForstall BruceForstall BruceForstall approved these changes

Assignees
No one assigned
Labels
arch-loongarch64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shushanhf @BruceForstall @teo-tsirpanis