Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LoongArch64] Fix the segment fault within JIT_UpdateWriteBarrierState. #69782

Merged
merged 3 commits into from
May 30, 2022

Conversation

shushanhf
Copy link
Contributor

@shushanhf shushanhf commented May 25, 2022

Hi, @janvorli
After #69672 merged, the LA had to follow it for segment fault.

(1) there is an segment fault for LA within JIT_UpdateWriteBarrierState;

Thread 1 "corerun" received signal SIGSEGV, Segmentation fault.
JIT_UpdateWriteBarrierState () at /home/qiao/work_qiao/push_runtime/src/coreclr/vm/loongarch64/asmhelpers.S:97
97	    st.d  $a0, $t2, 0

First, I had fixed this error by the first patch.

(2) another segment fault when writing the first instruction: (This error had been fixed by #69975

Thread 1 "corerun" received signal SIGSEGV, Segmentation fault.
0x000000ff7c7eb330 in emitter::emitOutputInstr (this=0xaaaabd1968, ig=0xaaaabe7240, id=0xaaaabebfc4, dp=0xfffffef050)
    at /home/qiao/work_qiao/push_runtime/src/coreclr/jit/emitloongarch64.cpp:3768
3768	            *(code_t*)dst = id->idAddr()->iiaGetInstrEncode();

This error is caused by the #69672 .
If export COMPlus_EnableWriteXorExecute=0 it will be ok.

This error had been fixed by #69975

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label May 25, 2022
@shushanhf
Copy link
Contributor Author

This is part of the issue #69705 to amend the LA's port.

@shushanhf
Copy link
Contributor Author

shushanhf commented May 26, 2022

Hi, @janvorli
Could you please review this PR and give me some advices ?

This error is caused by the #69672 .
If export COMPlus_EnableWriteXorExecute=0 it will be ok.

@shushanhf
Copy link
Contributor Author

Hi, @janvorli Could you please review this PR and give me some advices ?

This error is caused by the #69672 . If export COMPlus_EnableWriteXorExecute=0 it will be ok.

This error had been fixed by #69975

@shushanhf
Copy link
Contributor Author

Hi, @jkotas @mangod9 @janvorli
Could you please review this PR ?
Thanks

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jkotas jkotas merged commit 9956f2f into dotnet:main May 30, 2022
@shushanhf shushanhf deleted the main_vm2 branch May 31, 2022 00:29
@ghost ghost locked as resolved and limited conversation to collaborators Jun 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-loongarch64 area-VM-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants