Remove extraneous diagnostic #69830
Merged
Remove extraneous diagnostic #69830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the attribute. The C# compiler will already fail so just let it emit its diagnostics. Fixes #69827
jkoritzinsky
added
area-System.Runtime.InteropServices
source-generator
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsRemove the extra diagnostic we emit when the compiler failed to parse the attribute. The C# compiler will already fail so just let it emit its diagnostics. Fixes #69827
|
AaronRobinsonMSFT
approved these changes
May 25, 2022
elinor-fung
approved these changes
May 25, 2022
stephentoub
approved these changes
May 25, 2022
|
I'm cancelling the outerloop / jitstress / gcstress runs that were incorrectly triggered on this. |
|
Failures are #69792 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the extra diagnostic we emit when the compiler failed to parse the attribute. The C# compiler will already fail so just let it emit its diagnostics.
Fixes #69827