Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LoongArch64] enable the promote feature. #69840

Merged
merged 1 commit into from
May 27, 2022
Merged

[LoongArch64] enable the promote feature. #69840

merged 1 commit into from
May 27, 2022

Conversation

shushanhf
Copy link
Contributor

Enable the promote feature for LoongArch64.

This PR is part of the issue #69705

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label May 26, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 26, 2022
@ghost
Copy link

ghost commented May 26, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Enable the promote feature for LoongArch64.

This PR is part of the issue #69705

Author: shushanhf
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution
Milestone: -

@shushanhf
Copy link
Contributor Author

All the failed tests are about Send to Helix.

Hi, @BruceForstall
Could you please review this PR ?

@BruceForstall BruceForstall self-requested a review May 26, 2022 18:08
BruceForstall
BruceForstall approved these changes May 26, 2022
View reviewed changes
Copy link
Member

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Glad to see you enabling this!

I requested rerun of the failing tests and will merge after they complete successfully: there was a general infrastructure failure that should now be fixed.

@BruceForstall
Copy link
Member

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BruceForstall
Copy link
Member

Looks like the testing hit a new infra problem described here: #69878 (comment)

We'll have to wait for that to be resolved before rerunning testing.

@shushanhf
Copy link
Contributor Author

Looks like the testing hit a new infra problem described here: #69878 (comment)

We'll have to wait for that to be resolved before rerunning testing.

Yes, you are right.
Thanks very much for your review.

@BruceForstall
Copy link
Member

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BruceForstall BruceForstall merged commit 2a66135 into dotnet:main May 27, 2022
@shushanhf shushanhf deleted the main_promote branch May 28, 2022 03:13
@ghost ghost locked as resolved and limited conversation to collaborators Jun 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BruceForstall BruceForstall BruceForstall approved these changes

Assignees
No one assigned
Labels
arch-loongarch64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shushanhf @BruceForstall @teo-tsirpanis