Fix async handle leak when sync RandomAccess read/write on async handle fails #69956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't invoking user code and it's entirely for synchronous operations; there's no reason it needs to capture ExecutionContext.
stephentoub
requested review from
davidfowl,
jeffhandley,
adamsitnik,
kouvel and
jozkee
|
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsContributes to #69377
|
|
@jeffhandley, is there someone who can help review this? |
tannergooding
approved these changes
Jun 10, 2022
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/2475554499 |
|
@stephentoub backporting to release/6.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Fix async handle leak when sync RandomAccess read/write on async handle fails
Using index info to reconstruct a base tree...
M src/libraries/System.Private.CoreLib/src/System/IO/RandomAccess.Windows.cs
Falling back to patching base and 3-way merge...
Auto-merging src/libraries/System.Private.CoreLib/src/System/IO/RandomAccess.Windows.cs
CONFLICT (content): Merge conflict in src/libraries/System.Private.CoreLib/src/System/IO/RandomAccess.Windows.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix async handle leak when sync RandomAccess read/write on async handle fails
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
stephentoub
added a commit
to stephentoub/runtime
that referenced
this pull request
Jun 10, 2022
…le fails (dotnet#69956) * Fix async handle leak when sync RandomAccess read/write on async handle fails * Use UnsafeAllocateNativeOverlapped in GetNativeOverlappedForAsyncHandle This isn't invoking user code and it's entirely for synchronous operations; there's no reason it needs to capture ExecutionContext.
danmoseley
pushed a commit
that referenced
this pull request
Jun 14, 2022
…le fails (#69956) (#70591) * Fix async handle leak when sync RandomAccess read/write on async handle fails * Use UnsafeAllocateNativeOverlapped in GetNativeOverlappedForAsyncHandle This isn't invoking user code and it's entirely for synchronous operations; there's no reason it needs to capture ExecutionContext.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #69377