-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not use LEA
s in HIR
#69992
Merged
Merged
Do not use LEA
s in HIR
#69992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
May 30, 2022
ghost
added
the
community-contribution
Indicates that the PR has been added by a community member
label
May 30, 2022
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsThe canonical form of a Fixes #64375.
|
SingleAccretion
force-pushed
the
No-LEA-In-HIR
branch
from
May 31, 2022 08:23
e6c4bc1
to
9396394
Compare
@dotnet/jit-contrib |
In the frontend, for better or worse, the canonical form of address arithmetic is explicit pointer arithmetic.
SingleAccretion
force-pushed
the
No-LEA-In-HIR
branch
from
June 4, 2022 18:19
9396394
to
c0cfc6d
Compare
BruceForstall
approved these changes
Jun 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
community-contribution
Indicates that the PR has been added by a community member
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The canonical form of a
LEA
-equivalent expression in HIR is explicit address arithmetic.Fixes #64375.
Diffs - some improvements from
LCL_FLD
folding, some regressions from inserting the zero-extending casts. Also a small TP regression, payed for with #69958.