Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Host error message updates #70059

Merged
merged 2 commits into from
Jun 9, 2022

Conversation

elinor-fung
Copy link
Member

@elinor-fung elinor-fung commented Jun 1, 2022

Backport of #67564
Partial backport of #67022 (only the error message updates, nothing related to multi-level lookup)

Update messages for:

  • Runtime not found
  • Framework resolution failure
  • SDK resolution failure
  • dotnet --info

We have gotten a variety of feedback around improving the experience here (#56146),.

cc @richlander

Customer Impact

This change updates the error messages shown to an end user (or developer) when an app or SDK command cannot be run. It makes the messages more consistent with one another and adds more information to them, including a link to docs.

Testing

Updates to automated tests are included in the backport. Expected messages in the scenarios above were manually validated.

Risk

Low. The changes intentionally affect user-facing scenarios, but they are scoped to error messages and dotnet --info. There are a decent number of changes, but most of them are tests.

@ghost
Copy link

ghost commented Jun 1, 2022

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #67564
Partial backport of #67022 (only the error message updates, nothing related to multi-level lookup)

Update messages for:

  • Runtime not found
  • Framework resolution failure
  • SDK resolution failure
  • dotnet --info
Author: elinor-fung
Assignees: elinor-fung
Labels:

area-Host

Milestone: -

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. We will take for consideration in 6.0.x

@richlander
Copy link
Member

Not sure if it matters for Tactics, but I consider this feature to be an SDK not runtime feature from a breaking change concern perspective.

@JulieLeeMSFT JulieLeeMSFT added this to the 6.0.x milestone Jun 1, 2022
@JulieLeeMSFT JulieLeeMSFT added the Servicing-consider Issue for next servicing release review label Jun 1, 2022
@rbhanda rbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jun 2, 2022
@rbhanda rbhanda modified the milestones: 6.0.x, 6.0.7 Jun 2, 2022
@carlossanlop
Copy link
Member

Servicing-approved label applied. No CI failures. Area owners signed off.
:shipit:

@carlossanlop carlossanlop merged commit 90fcb77 into dotnet:release/6.0 Jun 9, 2022
@elinor-fung elinor-fung deleted the backportMessageUpdates branch June 10, 2022 17:07
@ghost ghost locked as resolved and limited conversation to collaborators Jul 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Host Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants