Modify tests to distinguish between emit- and interpreted-based invoke #70114
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-reflection Issue DetailsVerifying before review
|
| public static bool ForceEmitInvoke | ||
| { | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| get => GetCachedSwitchValue("Switches.System.Reflection.ForceEmitInvoke", ref s_forceEmitInvoke); |
There was a problem hiding this comment.
Other names in this file start with Switch.. Is Switches. here intentional or a mistake?
There was a problem hiding this comment.
Yikes - I'll change that thanks.
src/coreclr/System.Private.CoreLib/src/System/Reflection/MethodInvoker.CoreCLR.cs
Show resolved
Hide resolved
src/libraries/System.Reflection/tests/InvokeEmit/System.Reflection.InvokeEmit.Tests.csproj
Outdated
Show resolved
Hide resolved
| <AllowUnsafeBlocks>true</AllowUnsafeBlocks> | ||
| <TestRuntime>true</TestRuntime> | ||
| <IncludeRemoteExecutor>true</IncludeRemoteExecutor> | ||
| <TargetFrameworks>$(NetCoreAppCurrent)-windows;$(NetCoreAppCurrent)-Unix</TargetFrameworks> |
There was a problem hiding this comment.
Why do we need separate builds for Windows and Linux?
There was a problem hiding this comment.
Not sure; it's matching the original project except I didn't add -Browser.
There was a problem hiding this comment.
System.Runtime.Tests.csproj has conditional compilation for Windows vs. Unix, so it needs separate TargetFrameworks.
This project does not have any conditional compilation, so it should not need separate TargetFrameworks
There was a problem hiding this comment.
I'll let this CI run finish, and then change it to just NetCoreAppCurrent. I suspect that other tests were failing in the original project so we should be OK to change it here for just the subset of the reflection tests.
ghost
locked as resolved and limited conversation to collaborators
As a follow-up to #67917, explicitly support testing of both emit-based and interpreter-based invoke.
This is done using app context switches to enable the emit- or interpreter-based invoke and then adding new test projects to both the Runtime and Reflection solutions that set the appropriate context switch. The existing tests that use Invoke were added to these new test projects.
This is a replacement for PR #69081 which did not use app context switches.