Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Bump emscripten to 3.1.12 #70693

Merged
merged 34 commits into from
Jul 9, 2022
Merged

[wasm] Bump emscripten to 3.1.12 #70693

merged 34 commits into from
Jul 9, 2022

Conversation

radekdoulik
Copy link
Member

No description provided.

@radekdoulik radekdoulik self-assigned this Jun 13, 2022
@radekdoulik radekdoulik added this to the 7.0.0 milestone Jun 13, 2022
@radekdoulik
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Radek Doulik and others added 2 commits June 14, 2022 12:06
@radekdoulik
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radekdoulik
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radekdoulik
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@runfoapp runfoapp bot mentioned this pull request Jun 14, 2022
Closed
@radekdoulik
Copy link
Member Author

@radical some tests timeout on windows, could you please take a look? like this one https://helix.dot.net/api/2019-06-17/jobs/fce081ba-bfdc-47e4-a4ae-5c8709e1cb11/workitems/normal-System.Composition.AttributeModel.Tests/console

could it be the python bug again?

@radekdoulik
Ignore link errors coming from native refs
f2bfa1f 
This avoids this error, where the linker seems more strict now:

      [] EXEC : error : undefined symbol: _ZNKSt3__220__vector_base_commonILb1EE20__throw_length_errorEv (referenced by top-level compiled C/C++ code) [/datadisks/disk1/work/BDDD0A63/w/A3D60932/e/blz_nativeref_aot_Debug/blz_nativeref_aot_Debug.csproj]
      [] EXEC : warning : Link with `-sLLD_REPORT_UNDEFINED` to get more information on undefined symbols [/datadisks/disk1/work/BDDD0A63/w/A3D60932/e/blz_nativeref_aot_Debug/blz_nativeref_aot_Debug.csproj]
      [] EXEC : warning : To disable errors for undefined symbols use `-sERROR_ON_UNDEFINED_SYMBOLS=0` [/datadisks/disk1/work/BDDD0A63/w/A3D60932/e/blz_nativeref_aot_Debug/blz_nativeref_aot_Debug.csproj]
      [] EXEC : warning : __ZNKSt3__220__vector_base_commonILb1EE20__throw_length_errorEv may need to be added to EXPORTED_FUNCTIONS if it arrives from a system library [/datadisks/disk1/work/BDDD0A63/w/A3D60932/e/blz_nativeref_aot_Debug/blz_nativeref_aot_Debug.csproj]
      [] EXEC : error : undefined symbol: _ZNKSt3__221__basic_string_commonILb1EE20__throw_length_errorEv (referenced by top-level compiled C/C++ code) [/datadisks/disk1/work/BDDD0A63/w/A3D60932/e/blz_nativeref_aot_Debug/blz_nativeref_aot_Debug.csproj]
      [] EXEC : warning : __ZNKSt3__221__basic_string_commonILb1EE20__throw_length_errorEv may need to be added to EXPORTED_FUNCTIONS if it arrives from a system library [/datadisks/disk1/work/BDDD0A63/w/A3D60932/e/blz_nativeref_aot_Debug/blz_nativeref_aot_Debug.csproj]
      [] EXEC : error : Aborting compilation due to previous errors [/datadisks/disk1/work/BDDD0A63/w/A3D60932/e/blz_nativeref_aot_Debug/blz_nativeref_aot_Debug.csproj]
      [] emcc : error : '/datadisks/disk1/work/BDDD0A63/w/A3D60932/e/dotnet-workload/packs/Microsoft.NET.Runtime.Emscripten.3.1.12.Node.linux-x64/7.0.0-preview.6.22308.2/tools/bin/node
@radekdoulik
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member

radical commented Jun 15, 2022

could it be the python bug again?

No, python shouldn't be involved here. It's v8 timing out right before exit.

@radical
Copy link
Member

radical commented Jun 28, 2022

The WBT failures seem relevant here. The ones on main are with nodejs, but the ones failing here are with v8.

@radical radical added the arch-wasm WebAssembly architecture label Jun 28, 2022
@ghost
Copy link

ghost commented Jun 28, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: radekdoulik
Assignees: radekdoulik
Labels:

arch-wasm, area-Build-mono
Milestone: 7.0.0

@radekdoulik
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

radical added 2 commits July 8, 2022 21:17
@radical
Merge remote-tracking branch 'origin/main' into pr-bump-emscripten-3-…
e6a1bd9 
…1-12
@radical
[wasm] Don't run tests on windows with v8
1e9731a 
- We are only interested in testing with v8 on linux

This changes:
1. All the AOT tests to run with browser on windows
2. Library tests (interpreter) will run with browser, and nodejs
@radical
Copy link
Member

radical commented Jul 8, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member

radical commented Jul 9, 2022

wasm:
library test failure is #71843
highresource_aot failures are #71848

@radekdoulik radekdoulik requested a review from thaystg as a code owner July 9, 2022 07:49
@radical
Copy link
Member

radical commented Jul 9, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

radical added 2 commits July 9, 2022 08:04
@radical
Fix System.Net.Http.Functional.Tests failing due to trimming
b00e95c 
.. on Windows/AOT:

```
[00:44:42] info: Discovering: System.Net.Http.Functional.Tests.dll (method display = ClassAndMethod, method display options = None)
[00:44:43] fail: System.AggregateException: One or more errors occurred. (Unable to get member, please check input for IsSupported.)
 ---> System.InvalidOperationException: Unable to get member, please check input for IsSupported.
   at Xunit.Sdk.XunitTestCase.Initialize()
   at Microsoft.DotNet.XHarness.TestRunners.Xunit.XUnitFiltersCollection.IsExcludedInternal(IEnumerable`1 , Func`2 )
   at Microsoft.DotNet.XHarness.TestRunners.Xunit.XUnitFiltersCollection.IsExcluded(ITestCase , Action`1 )
   at System.Collections.Generic.List`1[[Xunit.Abstractions.ITestCase, xunit.abstractions, Version=2.0.0.0, Culture=neutral, PublicKeyToken=8d05b1bb7a6fdb6c]]..ctor(IEnumerable`1 )
   at Microsoft.DotNet.XHarness.TestRunners.Xunit.ThreadlessXunitTestRunner.Run(IEnumerable`1 )
   at Xunit.Sdk.XunitTestCase.Initialize()
   at Microsoft.DotNet.XHarness.TestRunners.Xunit.XUnitFiltersCollection.IsExcludedInternal(IEnumerable`1 , Func`2 )
   at Microsoft.DotNet.XHarness.TestRunners.Xunit.XUnitFiltersCollection.IsExcluded(ITestCase , Action`1 )
   at System.Collections.Generic.List`1[[Xunit.Abstractions.ITestCase, xunit.abstractions, Version=2.0.0.0, Culture=neutral, PublicKeyToken=8d05b1bb7a6fdb6c]]..ctor(IEnumerable`1 )
   at Microsoft.DotNet.XHarness.TestRunners.Common.ApplicationEntryPoint.InternalRunAsync(LogWriter )
   at Xunit.Sdk.XunitTestCase.Initialize()
   at Microsoft.DotNet.XHarness.TestRunners.Xunit.XUnitFiltersCollection.IsExcludedInternal(IEnumerable`1 , Func`2 )
   at Microsoft.DotNet.XHarness.TestRunners.Xunit.XUnitFiltersCollection.IsExcluded(ITestCase , Action`1 )
   at System.Collections.Generic.List`1[[Xunit.Abstractions.ITestCase, xunit.abstractions, Version=2.0.0.0, Culture=neutral, PublicKeyToken=8d05b1bb7a6fdb6c]]..ctor(IEnumerable`1 )
   at Microsoft.DotNet.XHarness.TestRunners.Common.ApplicationEntryPoint.InternalRunAsync(ApplicationOptions , TextWriter , TextWriter )
   at Xunit.Sdk.XunitTestCase.Initialize()
   at Microsoft.DotNet.XHarness.TestRunners.Xunit.XUnitFiltersCollection.IsExcludedInternal(IEnumerable`1 , Func`2 )
   at Microsoft.DotNet.XHarness.TestRunners.Xunit.XUnitFiltersCollection.IsExcluded(ITestCase , Action`1 )
   at System.Collections.Generic.List`1[[Xunit.Abstractions.ITestCase, xunit.abstractions, Version=2.0.0.0, Culture=neutral, PublicKeyToken=8d05b1bb7a6fdb6c]]..ctor(IEnumerable`1 )
   at Microsoft.DotNet.XHarness.TestRunners.Common.WasmApplicationEntryPointBase.RunAsync()
   at Xunit.Sdk.XunitTestCase.Initialize()
   at Microsoft.DotNet.XHarness.TestRunners.Xunit.XUnitFiltersCollection.IsExcludedInternal(IEnumerable`1 , Func`2 )
   at Microsoft.DotNet.XHarness.TestRunners.Xunit.XUnitFiltersCollection.IsExcluded(ITestCase , Action`1 )
   at System.Collections.Generic.List`1[[Xunit.Abstractions.ITestCase, xunit.abstractions, Version=2.0.0.0, Culture=neutral, PublicKeyToken=8d05b1bb7a6fdb6c]]..ctor(IEnumerable`1 )
   at Microsoft.DotNet.XHarness.TestRunners.Xunit.WasmApplicationEntryPoint.Run()
   at Xunit.Sdk.XunitTestCase.Initialize()
   at Microsoft.DotNet.XHarness.TestRunners.Xunit.XUnitFiltersCollection.IsExcludedInternal(IEnumerable`1 , Func`2 )
   at Microsoft.DotNet.XHarness.TestRunners.Xunit.XUnitFiltersCollection.IsExcluded(ITestCase , Action`1 )
   at System.Collections.Generic.List`1[[Xunit.Abstractions.ITestCase, xunit.abstractions, Version=2.0.0.0, Culture=neutral, PublicKeyToken=8d05b1bb7a6fdb6c]]..ctor(IEnumerable`1 )
   at SimpleWasmTestRunner.Main(String[] )
   --- End of inner exception stack trace ---
```
@radical
Merge remote-tracking branch 'origin/main' into pr-bump-emscripten-3-…
bd3aa62 
…1-12
@radical radical force-pushed the pr-bump-emscripten-3-1-12 branch from 4ea503a to bd3aa62 Compare July 9, 2022 08:06
@radical
Copy link
Member

radical commented Jul 9, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical radical mentioned this pull request Jul 9, 2022
Open
@radical
Copy link
Member

radical commented Jul 9, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member

radical commented Jul 9, 2022

wasm/HighResource_AOT failure is #71848
The WBT failure is known, and unrelated to this PR.

@radical radical merged commit 246f2c8 into dotnet:main Jul 9, 2022
@lambdageek lambdageek mentioned this pull request Jul 10, 2022
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Aug 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radical radical radical approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@thaystg thaystg Awaiting requested review from thaystg

Assignees

@radekdoulik radekdoulik

Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@radekdoulik @radical