Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Tar timestamp conversion from/to string and DateTimeOffset #71038

Merged
merged 12 commits into from
Jun 23, 2022
Merged

Fix Tar timestamp conversion from/to string and DateTimeOffset #71038

merged 12 commits into from
Jun 23, 2022

Commits on Jun 22, 2022

  1. Change double to decimal in timestamp conversions to preserve precision

    @carlossanlop
    carlossanlop committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    529e4c0 View commit details
    Browse the repository at this point in the history

  2. Re-enable disabled test

    @carlossanlop
    carlossanlop committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    d52a541 View commit details
    Browse the repository at this point in the history

  3. Adjust assert message

    @carlossanlop
    carlossanlop committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    33974cd View commit details
    Browse the repository at this point in the history

  4. Reuse FileSystemInfo Last*TimeUtc fields, use implicit cast operator … 

    …to store as DateTimeOffset.
    @carlossanlop
    carlossanlop committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    9973fcd View commit details
    Browse the repository at this point in the history

  5. Fix using wrong fieldname for ctime.

    @carlossanlop
    carlossanlop committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    c8df15b View commit details
    Browse the repository at this point in the history

  6. Using 'G' for decimal to string conversion. Adjust test to not requir… 

    …e a dot. The DateTimeOffset comparison done afterwards should suffice.
    @carlossanlop
    carlossanlop committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    44789fc View commit details
    Browse the repository at this point in the history

  7. Ensure timestamps are converted to long, not int.

    @carlossanlop
    carlossanlop committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    17e6060 View commit details
    Browse the repository at this point in the history

  8. Add Epochalypse and Past-octal-limit timestamp tests

    @carlossanlop
    carlossanlop committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    9f81016 View commit details
    Browse the repository at this point in the history

  9. TarHelpers methods can be private

    @carlossanlop
    carlossanlop committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    7fa8776 View commit details
    Browse the repository at this point in the history

  10. Remove unreachable code for adding ctime and atime before writing Pax… 

    … entry. Add tests to ensure we always add those entries to the dictionary on construction.
    @carlossanlop
    carlossanlop committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    dc29c6b View commit details
    Browse the repository at this point in the history

  11. Fix typo in test when retrieving ctime.

    @carlossanlop
    carlossanlop committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    c7a0923 View commit details
    Browse the repository at this point in the history

  12. Make sure CTime adds nanoseconds on Unix when retrieving info from disk.

    @carlossanlop
    carlossanlop committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    cad5599 View commit details
    Browse the repository at this point in the history