Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SString::UIndex and SString::UIterator as they are never used. #71103

Merged
merged 1 commit into from
Jun 22, 2022
Merged

Remove SString::UIndex and SString::UIterator as they are never used. #71103

merged 1 commit into from
Jun 22, 2022

Conversation

jkoritzinsky
Copy link
Member

This is based on work in #69748.

@jkoritzinsky jkoritzinsky requested a review from jkotas June 21, 2022 23:09
@ghost ghost assigned jkoritzinsky Jun 21, 2022
jkotas
jkotas approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jkotas
Copy link
Member

jkotas commented Jun 22, 2022

Installer failure is #70969

@jkoritzinsky jkoritzinsky merged commit 11b746a into dotnet:main Jun 22, 2022
@jkoritzinsky jkoritzinsky deleted the sstring-remove-dead-code branch June 22, 2022 03:06
@ghost ghost locked as resolved and limited conversation to collaborators Jul 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT approved these changes

@jkotas jkotas jkotas approved these changes

Assignees

@jkoritzinsky jkoritzinsky

Labels
area-VM-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkoritzinsky @jkotas @AaronRobinsonMSFT