Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spill all nodes multi-reg morphing does not handle #71127

Merged

Conversation

SingleAccretion
Copy link
Contributor

@SingleAccretion SingleAccretion commented Jun 22, 2022

This set now includes COMMAs. We could handle those, but they're very rare, so I opted for the simple and conservative fix.

Fixes #71118.

No diffs as expected.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 22, 2022
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jun 22, 2022
@ghost
Copy link

ghost commented Jun 22, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

This set now includes COMMAs. We could handle those, but they're very rare, so I opted for the simple and conservative fix.

Fixes #71118.

Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@SingleAccretion SingleAccretion marked this pull request as ready for review June 22, 2022 22:43
@SingleAccretion
Copy link
Contributor Author

Installer failures are #70969.

@dotnet/jit-contrib

@jakobbotsch jakobbotsch merged commit b122149 into dotnet:main Jun 23, 2022
@SingleAccretion SingleAccretion deleted the Commas-In-Multi-Reg-Morphing-Upstream branch June 23, 2022 10:46
@ghost ghost locked as resolved and limited conversation to collaborators Jul 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JIT ARM64: Assertion failed 'argValue->OperIsIndir()' during 'Morph - Global'
2 participants