Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Conditional nodes and Arm64 code generation #71616

Merged
merged 1 commit into from
Jul 5, 2022
Merged

Add Conditional nodes and Arm64 code generation #71616

merged 1 commit into from
Jul 5, 2022

Conversation

a74nh
Copy link
Contributor

@a74nh a74nh commented Jul 4, 2022

No description provided.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 4, 2022
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jul 4, 2022
@ghost
Copy link

ghost commented Jul 4, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: a74nh
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@a74nh
Copy link
Contributor Author

a74nh commented Jul 4, 2022

This patch is a subset of #67894
It contains just the definition of the nodes plus the Arm64 code generation.

with this patch nothing uses the conditional nodes, so the impact on code gen should be zero.

@a74nh a74nh mentioned this pull request Jul 4, 2022
Closed
@kunalspathak
Copy link
Member

For completion, this should also include changes to LSRA, right?

@a74nh
Copy link
Contributor Author

a74nh commented Jul 5, 2022

For completion, this should also include changes to LSRA, right?

Yes, it probably should. I'll add it in.

For reference, these are the files I've got in the next patch after this:

 src/coreclr/jit/compiler.h       |  28 +++++++++++++++++++++++
 src/coreclr/jit/compiler.hpp     |  21 +++++++++++++++++
 src/coreclr/jit/gentree.cpp      | 123 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
 src/coreclr/jit/gentree.h        |  10 ++++++++
 src/coreclr/jit/lir.cpp          |   4 ++--
 src/coreclr/jit/liveness.cpp     |  10 +++++++-
 src/coreclr/jit/lower.cpp        | 135 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------------------
 src/coreclr/jit/lower.h          |   4 ++--
 src/coreclr/jit/lowerarmarch.cpp |   8 +++++++
 src/coreclr/jit/lowerxarch.cpp   |  20 ++++++++++------
 src/coreclr/jit/lsraarm64.cpp    |  18 +++++++++++++++
 11 files changed, 328 insertions(+), 53 deletions(-)

kunalspathak
kunalspathak approved these changes Jul 5, 2022
View reviewed changes
Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A question, but overall LGTM.

src/coreclr/jit/emitarm64.cpp
@@ -12980,7 +12986,7 @@ void emitter::emitDispInsHelp(
cfi.immCFVal = (unsigned)emitGetInsSC(id);
emitDispImm(cfi.imm5, true);
emitDispFlags(cfi.flags);
printf(",");
printf(", ");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It gives us: ccmp w1, #10, z, lt
instead of ccmp w1, #10, z,lt

@kunalspathak
Copy link
Member

these are the files I've got in the next patch after this:

Thanks, that should be fine then. I will just rerun the failing job before merging.

@kunalspathak kunalspathak merged commit 5384c95 into dotnet:main Jul 5, 2022
@a74nh a74nh mentioned this pull request Jul 6, 2022
Merged
@a74nh
Copy link
Contributor Author

a74nh commented Jul 6, 2022

Next part is here: #71705

@a74nh a74nh deleted the github_a74nh_csel_codegen branch July 6, 2022 10:44
@JulieLeeMSFT JulieLeeMSFT mentioned this pull request Jul 28, 2022
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Aug 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kunalspathak kunalspathak kunalspathak approved these changes

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a74nh @kunalspathak