Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of hardcoded sleep in tracing/runtimeeventsource/nativeruntimeeventsource #72010

Merged
merged 3 commits into from
Jul 14, 2022
Merged

Get rid of hardcoded sleep in tracing/runtimeeventsource/nativeruntimeeventsource #72010

merged 3 commits into from
Jul 14, 2022

Conversation

davmason
Copy link
Member

Fixes #71331

This test was failing because in some runs the event would take longer than 2 seconds to get all the way through the eventing pipeline.

@davmason davmason added this to the 7.0.0 milestone Jul 12, 2022
@davmason davmason requested review from EgorBo, AndyAyersMS and a team July 12, 2022 10:54
@davmason davmason self-assigned this Jul 12, 2022
@davmason davmason mentioned this pull request Jul 12, 2022
Closed
noahfalk
noahfalk approved these changes Jul 12, 2022
View reviewed changes
Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo comments

src/tests/tracing/runtimeeventsource/NativeRuntimeEventSourceTest.cs Outdated Show resolved Hide resolved
@davmason
Copy link
Member Author

Fixes #70966

This was linked to issues Jul 13, 2022
Test failure tracing\\runtimeeventsource\\nativeruntimeeventsource\\nativeruntimeeventsource.cmd #70966
Closed
Test failure tracing/runtimeeventsource/nativeruntimeeventsource/nativeruntimeeventsource.sh #68690
Closed
@davmason
Copy link
Member Author

This fixes #70966 (unsafe multithreaded hashset access) and #68690 (we would occasionally see no events at all in GCStress/JITStress) as well.

@davmason davmason merged commit 1a0c9ca into dotnet:main Jul 14, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aromaa aromaa aromaa left review comments

@jakobbotsch jakobbotsch jakobbotsch left review comments

@EgorBo EgorBo EgorBo approved these changes

@noahfalk noahfalk noahfalk approved these changes

@AndyAyersMS AndyAyersMS Awaiting requested review from AndyAyersMS

Assignees

@davmason davmason

Labels
area-Tracing-coreclr
Projects
None yet
Milestone
7.0.0
5 participants
@davmason @EgorBo @aromaa @noahfalk @jakobbotsch