Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0-preview7] Mark JsonSerializerOptions.TypeInfoResolver as nullable and linker-safe #72087

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jul 13, 2022

Backport of #72044 to release/7.0-preview7

/cc @eiriktsarpalis

Customer Impact

This is a last-minute update to the nullability/linkability semantics of a key property in the new System.Text.Json contract customization feature that barely missed the snap deadline. We want to make sure that the change gets appropriate soak time by being incorporated in Preview 7. See #71960 for more details on the technical reasons that motivated the change.

Testing

Tests have been updated to reflect the changed semantics where appropriate.

Risk

Low. Changing semantics of a pre-release feature.

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Jul 13, 2022

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #72044 to release/7.0-preview7

/cc @eiriktsarpalis

Customer Impact

Testing

Risk

IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Text.Json, new-api-needs-documentation

Milestone: -

@carlossanlop carlossanlop added Servicing-consider Issue for next servicing release review Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jul 13, 2022
@carlossanlop
Copy link
Member

Approved for servicing via email. Merging.

@carlossanlop carlossanlop merged commit 9cc6254 into release/7.0-preview7 Jul 13, 2022
@eiriktsarpalis eiriktsarpalis deleted the backport/pr-72044-to-release/7.0-preview7 branch July 13, 2022 18:54
@ghost ghost locked as resolved and limited conversation to collaborators Aug 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants