Code

[Unix] Console.ReadKey rewrite#72193

Code

Merged

adamsitnik merged 42 commits intodotnet:maindotnet/runtime:mainfrom adamsitnik:consoleReadKeyadamsitnik/runtime:consoleReadKeyCopy head branch name to clipboardAug 1, 2022

+3,337-972

Commits

Commits on Jun 28, 2022

• move WellKnownStrings to a separate file

  adamsitnik

  committed
  d929235

• move Database to separate file

  adamsitnik

  committed
  c8887ec

• move factory logic to DatabaseFactory so the test project does not need to reference all sys-calls used for reading files

  adamsitnik

  committed
  cf77107

• move WellKnownNumbers to separate file

  adamsitnik

  committed
  c6f3a60

• include Database in the test project

  adamsitnik

  committed
  acd4f24

• move TerminalFormatStrings to a separate file

  adamsitnik

  committed
  f5e3641

• include TerminalFormatStrings in test project

  adamsitnik

  committed
  d3cdb93

• fix existing tests

  adamsitnik

  committed
  7ea9f50

Commits on Jun 29, 2022

• move the key mapping logic to a separate class, do NOT change it

  adamsitnik

  committed
  dc0af6b

Commits on Jul 1, 2022

• simple tests for ASCII characters

  adamsitnik

  committed
  c927091

Commits on Jul 5, 2022

• test cases for xterm and xterm-256color

  adamsitnik

  committed
  f30f02e

Commits on Jul 6, 2022

• add PuTTY and UXTern

  adamsitnik

  committed
  5ffdd67

• add Windows Terminal data

  adamsitnik

  committed
  9230c81

• add more PuTTY test cases

  adamsitnik

  committed
  41a92bf

• handle empty encodings

  adamsitnik

  committed
  af92ab3

Commits on Jul 7, 2022

• make it possible to run the tests on Windows so I can use my favourite dev env

  adamsitnik

  committed
  9a2ed71

• add mappings for single characters

  adamsitnik

  committed
  69f12c9

Commits on Jul 8, 2022

• add mappings for 3 characters

  adamsitnik

  committed
  5bbac1d

• fix test cases where pressing Ctrl/Alt/Shift + other key produces two bytes which represent single UTF8 character by design

  adamsitnik

  committed
  a9db7db

Commits on Jul 9, 2022

• handle more complex sequences (with modifiers)

  adamsitnik

  committed
  c2e02d8

Commits on Jul 11, 2022

• handle edge cases properly

  adamsitnik

  committed
  620d1a0

• add tmux test data

  adamsitnik

  committed
  20593ef

• add rxvt-unicode test data and implementation for rxvt modifiers

  adamsitnik

  committed
  c612f4f

Commits on Jul 12, 2022

• polishing

  adamsitnik

  committed
  3e62636

• switch to the new implementation and allow the users to differentiate between Enter (\r) and Ctrl+Enter (\n) like we do on Windows

  adamsitnik

  committed
  aa07430

Commits on Jul 13, 2022

• add way more test cases and fix identified issues

  Show description for 254c762
  adamsitnik

  committed
  254c762

• polishing: reorder the tests

  adamsitnik

  committed
  4023725

Commits on Jul 14, 2022

• fix compiler error (it's strange as I was not getting it when I was building Console solution only)

  adamsitnik

  committed
  d65c6e7

• add more SCO mappings

  adamsitnik

  committed
  8cd9e3d

• Numeric Keypad

  adamsitnik

  committed
  7fea037

• Merge remote-tracking branch 'upstream/main' into consoleReadKey

  Show description for 16e983f
  adamsitnik

  committed
  16e983f

Commits on Jul 21, 2022

• add Tmux 256 color test cases (TERM=screen-256color)

  adamsitnik

  committed
  dd07418

• add two Numeric Keypad test cases: period & Enter

  adamsitnik

  committed
  632267c

• fix issue discovered by adding more tmux test cases: ^[OM should be mapped to Enter

  adamsitnik

  committed
  69f6434

• address code review feedback: move TerminalFormatStrings classs out if ConsolePal

  adamsitnik

  committed
  9c352b4

• address code review feedback: handle all variants of tmux when getting title

  adamsitnik

  committed
  f974992

• address code review feedback: reduce number of out parameters

  adamsitnik

  committed
  b3366a8

• fix TermInfo tests

  adamsitnik

  committed
  dc82fb5

• add .NET 6 compat switch

  adamsitnik

  committed
  214da94

Commits on Aug 1, 2022

• Apply suggestions from code review

  Show description for 7766ed3
  

  adamsitnik

  and

  jozkee

  authored
  7766ed3

• address code review feedback

  adamsitnik

  committed
  c8010c5

• Merge branch 'main' into consoleReadKey

  adamsitnik

  authored
  c28d600