Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUIC] Fixed disabled receives if buffer gets drained before RECEIVE returns #72439

Merged
merged 2 commits into from
Jul 19, 2022
Merged

[QUIC] Fixed disabled receives if buffer gets drained before RECEIVE returns #72439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83ec947
Fixed disabled receives if buffer gets drained before RECEIVE returns
ManickaP Jul 19, 2022
9f9c4aa
Feedback
ManickaP Jul 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/libraries/System.Net.Quic/src/System/Net/Quic/Internal/ReceiveBuffers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,14 @@ public void SetFinal()
}
}

public bool HasCapacity()
{
lock (_syncRoot)
{
return _buffer.ActiveMemory.Length < MaxBufferedBytes;
}
}

public int CopyFrom(ReadOnlySpan<QUIC_BUFFER> quicBuffers, int totalLength, bool final)
{
lock (_syncRoot)
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.Net.Quic/src/System/Net/Quic/QuicStream.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,7 +509,7 @@ private unsafe int HandleEventReceive(ref RECEIVE data)
_receiveTcs.TrySetResult();

data.TotalBufferLength = totalCopied;
return QUIC_STATUS_SUCCESS;
return (_receiveBuffers.HasCapacity() && Interlocked.CompareExchange(ref _receivedNeedsEnable, 0, 1) == 1) ? QUIC_STATUS_CONTINUE : QUIC_STATUS_SUCCESS;
}
private unsafe int HandleEventSendComplete(ref SEND_COMPLETE data)
{
Expand Down