Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Enable Diagnostics.Tracing tests #72545

Merged
merged 10 commits into from
Jul 25, 2022
Merged

[iOS] Enable Diagnostics.Tracing tests #72545

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9a3ebbf
[iOS] Enable Diagnostics.Tracing tests
Jul 20, 2022
8d7e6a2
Merge remote-tracking branch 'origin/main' into enable-diag-tracing-ios
radical Jul 21, 2022
2b9204f
MonoAOTCompiler: Ensure `.aotdata` files end up next to the original …
radical Jul 21, 2022
97b1e6a
MonoAOTCompiler: Correctly handle assemblies to skip for aot, and
radical Jul 21, 2022
303f469
Re-enable more iOS tests and set diagnostics_tracing runtime component
Jul 22, 2022
a5f5b5a
MonoAOTCompiler: revert hack for .aotdata files on ios
radical Jul 22, 2022
0cccd0d
Merge remote-tracking branch 'origin/main' into enable-diag-tracing-ios
radical Jul 22, 2022
1b81263
MonoAOTCompiler: emit a message instead of a warning when skipping un…
radical Jul 22, 2022
972cd2b
Add AppleAppBuilder change that reads path in from AotDataFile item
Jul 25, 2022
3fe3b2f
Properly enable tracing tests
Jul 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/libraries/tests.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,6 @@

<!-- App Crash https://github.com/dotnet/runtime/issues/53624 -->
<ProjectExclusions Include="$(MSBuildThisFileDirectory)Microsoft.CSharp/tests/Microsoft.CSharp.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Diagnostics.Tracing/tests/System.Diagnostics.Tracing.Tests.csproj" />
mdh1418 marked this conversation as resolved.
Show resolved Hide resolved
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Dynamic.Runtime/tests/System.Dynamic.Runtime.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Linq.Expressions/tests/System.Linq.Expressions.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Net.Requests/tests/System.Net.Requests.Tests.csproj" />
Expand Down
4 changes: 2 additions & 2 deletions src/tasks/AotCompilerTask/MonoAOTCompiler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,8 +484,8 @@ private bool ExecuteInternal()
if (!ProcessAndValidateArguments())
return false;

_assembliesToCompile = EnsureAndGetAssembliesInTheSameDir(Assemblies);
_assembliesToCompile = FilterAssemblies(_assembliesToCompile);
_assembliesToCompile = FilterAssemblies(Assemblies);
_assembliesToCompile = EnsureAndGetAssembliesInTheSameDir(_assembliesToCompile);

if (!string.IsNullOrEmpty(AotModulesTablePath) && !GenerateAotModulesTable(_assembliesToCompile, Profilers, AotModulesTablePath))
return false;
Expand Down