[LoongArch64] amend the LoongArch64's ABI for GCstress and NullableObject. #72573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
ghost
added
the
community-contribution
|
Hi, @jkotas Could you please review this PR? |
jkotas
reviewed
Jul 21, 2022
| @@ -1810,7 +1810,7 @@ bool GcInfoDecoder::IsScratchRegister(int regNum, PREGDISPLAY pRD) | |||
| { | |||
| _ASSERTE(regNum >= 0 && regNum <= 31); | |||
|
|
|||
| return (regNum <= 21 && regNum >= 4); | |||
| return (regNum <= 21 && ((regNum >= 4) || (regNum == 1))); | |||
There was a problem hiding this comment.
Why would one store GC pointers in the return address register?
There was a problem hiding this comment.
because the ra may be used as a scratch register at some causes.
jkotas
approved these changes
Jul 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the issue #69705 to amend the LA's port.
Amends the LoongArch64's ABI for GCstress and NullableObject.
@HFDude Thanks for your helping fixing nullable testing.