[wasm-ep] diagnostic server IPC fixups #72859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The protocol spec says there's a length and a nul terminator, but sending that literal UTF-16 nul to ep_enable_2 means we use an incorrect name when looking for the provider.
lambdageek
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsThe protocol spec says there's a length and a nul terminator, but sending that literal UTF-16 nul to
|
convert the 64-bit "keywords" mask into a hex string properly by padding both halves with zeroes after calling the JS Number.toString() method
lambdageek
changed the title
campersau
reviewed
Jul 27, 2022
| const provisionalString = String.fromCharCode.apply(null, result); | ||
|
|
||
| if (trailingNulStart >= 0) | ||
| return provisionalString.substring(0, trailingNulStart); |
There was a problem hiding this comment.
Why substring the string instead of slicing the array?
There was a problem hiding this comment.
Changed it to use Array.splice instead. Thanks!
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kg
reviewed
Jul 28, 2022
| @@ -14,7 +14,7 @@ | |||
| </PropertyGroup> | |||
|
|
|||
| <PropertyGroup> | |||
| <MonoDiagnosticsMock Condition="'$(MonoDiagnosticsMock)' == ''">false</MonoDiagnosticsMock> | |||
| <MonoDiagnosticsMock Condition="'$(MonoDiagnosticsMock)' == '' and '$(Configuration)' == 'Debug' ">true</MonoDiagnosticsMock> | |||
There was a problem hiding this comment.
Wrap the two comparisons in parens please
kg
reviewed
Jul 28, 2022
|
|
||
| /* Trim trailing nul character(s) that are added by the protocol */ | ||
| let trailingNulStart = -1; | ||
| if (result.length > 0) { |
There was a problem hiding this comment.
i don't think this if is necessary since the loop termination condition will bail out
kg
approved these changes
Jul 28, 2022
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ep_enable_2means we use an incorrect name when looking for the provider.