Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SslStress docker build #72940

Merged
merged 1 commit into from
Jul 28, 2022
Merged

Fix SslStress docker build #72940

merged 1 commit into from
Jul 28, 2022

Conversation

antonfirsov
Copy link
Member

Fixes #72399, broken by #62102

@ghost
Copy link

ghost commented Jul 27, 2022

Tagging subscribers to this area: @dotnet/ncl, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #72399, broken by #62102

Author: antonfirsov
Assignees: -
Labels:

area-System.Net.Security

Milestone: -

@antonfirsov
Copy link
Member Author

/azp run runtime-libraries stress-http

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@antonfirsov antonfirsov requested a review from a team July 27, 2022 14:25
@am11
Copy link
Member

am11 commented Jul 27, 2022

broken by #62102

#62102 changed non-empty string comparison

 if [[ "$imagename" != "" ]]; then

to non-zero length comparison

 if [[ -n "$imagename" ]]; then

which is correct drop-in replacement. This means it was broken before my change...

@am11
Copy link
Member

am11 commented Jul 27, 2022

Ah, I was looking at HttpStress, the change in SslStress was wrong. Sorry about that. 🙂

Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antonfirsov
Copy link
Member Author

/azp run runtime-libraries stress-ssl

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@antonfirsov
Copy link
Member Author

/azp run runtime-libraries stress-ssl

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@antonfirsov antonfirsov merged commit b31a48a into main Jul 28, 2022
@jkotas jkotas deleted the antonfirsov-patch-1 branch July 28, 2022 19:08
@karelz karelz added this to the 7.0.0 milestone Aug 7, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SslStress fails to build on Linux
4 participants