Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NativeAOT tests interopservices #73200

Conversation

AaronRobinsonMSFT
Copy link
Member

Contributes to #73145

/cc @MichalStrehovsky @jkotas

Remove SetWin32ContextInIDispatchAttribute attribute and tests.
  - this was no longer in the ref assembly so just removing it.
@ghost
Copy link

ghost commented Aug 2, 2022

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #73145

/cc @MichalStrehovsky @jkotas

Author: AaronRobinsonMSFT
Assignees: -
Labels:

area-System.Runtime.InteropServices

Milestone: 7.0.0

Copy link
Member

@MichalStrehovsky MichalStrehovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this! This helps a lot!

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo comments.

Copy link
Member

@elinor-fung elinor-fung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay for the managed COM server and removing the surprise dependency on some AD type.

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit 9f1dd1a into dotnet:main Aug 4, 2022
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the nativeaot_tests_interopservices branch August 4, 2022 22:12
@ghost ghost locked as resolved and limited conversation to collaborators Sep 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants