Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Make Wasm.Build.Tests on CI, green again #73314

Merged
merged 2 commits into from
Aug 3, 2022
Merged

[wasm] Make Wasm.Build.Tests on CI, green again #73314

merged 2 commits into from
Aug 3, 2022

Conversation

radical
Copy link
Member

@radical radical commented Aug 3, 2022

@ghost ghost assigned radical Aug 3, 2022
@radical
Copy link
Member Author

radical commented Aug 3, 2022

WBT will run automatically, so runtime-wasm isn't needed.

@ghost
Copy link

ghost commented Aug 3, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
Author: radical
Assignees: -
Labels:

arch-wasm, area-Build-mono, test-failure
Milestone: -

@radical
Copy link
Member Author

radical commented Aug 3, 2022

OSX/NativeAOT failure likely fixed by #73235 . And unrelated to this PR.
Merging this to unblock CI.

@radical radical merged commit bb3be81 into dotnet:main Aug 3, 2022
@radical radical deleted the wbt-green branch August 3, 2022 21:41
@ghost ghost locked as resolved and limited conversation to collaborators Sep 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pavelsavara pavelsavara pavelsavara approved these changes

@lewing lewing Awaiting requested review from lewing

@radekdoulik radekdoulik Awaiting requested review from radekdoulik

@thaystg thaystg Awaiting requested review from thaystg

Assignees

@radical radical

Labels
arch-wasm WebAssembly architecture area-Build-mono test-failure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radical @pavelsavara