Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mono] Remove active issues for https://github.com/dotnet/runtime/issues/57506 #73492

Merged
merged 2 commits into from
Aug 15, 2022
Merged

[mono] Remove active issues for https://github.com/dotnet/runtime/issues/57506 #73492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6909de3
Remove active issues for https://github.com/dotnet/runtime/issues/57506
lewing Aug 5, 2022
85fa359
Remove AssemblyInfo.cs references
lewing Aug 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/libraries/System.Net.Requests/tests/HttpWebRequestTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,12 @@ namespace System.Net.Tests
{
using Configuration = System.Net.Test.Common.Configuration;

[ActiveIssue("https://github.com/dotnet/runtime/issues/57506", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsMariner))]
public sealed class HttpWebRequestTest_Async : HttpWebRequestTest
{
public HttpWebRequestTest_Async(ITestOutputHelper output) : base(output) { }
protected override Task<WebResponse> GetResponseAsync(HttpWebRequest request) => request.GetResponseAsync();
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/57506", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsMariner))]
public sealed class HttpWebRequestTest_Sync : HttpWebRequestTest
{
public HttpWebRequestTest_Sync(ITestOutputHelper output) : base(output) { }
Expand Down
3 changes: 1 addition & 2 deletions src/libraries/System.Net.Security/tests/FunctionalTests/AssemblyInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,4 @@
using Xunit;

[assembly: ActiveIssue("https://github.com/dotnet/runtime/issues/34690", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
[assembly: ActiveIssue("https://github.com/dotnet/runtime/issues/57506", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsMariner))]
[assembly: SkipOnPlatform(TestPlatforms.Browser, "System.Net.Security is not supported on Browser")]
[assembly: SkipOnPlatform(TestPlatforms.Browser, "System.Net.Security is not supported on Browser")]
7 changes: 0 additions & 7 deletions src/libraries/System.Security.Cryptography.Pkcs/tests/AssemblyInfo.cs
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion ...es/System.Security.Cryptography.Pkcs/tests/System.Security.Cryptography.Pkcs.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
Link="CommonTest\System\Security\Cryptography\PlatformSupport.cs" />
<Compile Include="$(CommonTestPath)System\Security\Cryptography\SignatureSupport.cs"
Link="CommonTest\System\Security\Cryptography\SignatureSupport.cs" />
<Compile Include="AssemblyInfo.cs" />
<Compile Include="Certificates.cs" />
<Compile Include="CertLoader.cs" />
<Compile Include="CertLoader.Settings.cs" />
Expand Down
8 changes: 0 additions & 8 deletions src/libraries/System.Security.Cryptography.X509Certificates/tests/AssemblyInfo.cs
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion ...y.Cryptography.X509Certificates/tests/CertificateCreation/CertificateRequestChainTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@

namespace System.Security.Cryptography.X509Certificates.Tests.CertificateCreation
{
[ActiveIssue("https://github.com/dotnet/runtime/issues/57506", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsMariner))]
public static class CertificateRequestChainTests
{
public static bool PlatformSupportsPss { get; } = DetectPssSupport();
Expand Down
1 change: 0 additions & 1 deletion src/libraries/System.Security.Cryptography.X509Certificates/tests/ChainTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@

namespace System.Security.Cryptography.X509Certificates.Tests
{
[ActiveIssue("https://github.com/dotnet/runtime/issues/57506", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsMariner))]
public static class ChainTests
{
private static bool TrustsMicrosoftDotComRoot
Expand Down
2 changes: 0 additions & 2 deletions src/libraries/System.Security.Cryptography.X509Certificates/tests/CollectionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -886,7 +886,6 @@ public static void X509CertificateCollectionCopyTo()
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNonZeroLowerBoundArraySupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/57506", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsMariner))]
public static void X509ChainElementCollection_CopyTo_NonZeroLowerBound_ThrowsIndexOutOfRangeException()
{
using (var microsoftDotCom = new X509Certificate2(TestData.MicrosoftDotComSslCertBytes))
Expand Down Expand Up @@ -1302,7 +1301,6 @@ public static void X509Certificate2CollectionGetHashCode()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/57506", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsMariner))]
public static void X509ChainElementCollection_IndexerVsEnumerator()
{
using (var microsoftDotCom = new X509Certificate2(TestData.MicrosoftDotComSslCertBytes))
Expand Down
1 change: 0 additions & 1 deletion src/libraries/System.Security.Cryptography.X509Certificates/tests/DynamicChainTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@

namespace System.Security.Cryptography.X509Certificates.Tests
{
[ActiveIssue("https://github.com/dotnet/runtime/issues/57506", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsMariner))]
public static class DynamicChainTests
{
private static X509Extension BasicConstraintsCA => new X509BasicConstraintsExtension(
Expand Down
1 change: 0 additions & 1 deletion src/libraries/System.Security.Cryptography.X509Certificates/tests/FindTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,6 @@ public static void FindByValidThumbprint_ValidOnly(bool validOnly)
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/57506", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsMariner))]
[SkipOnPlatform(PlatformSupport.MobileAppleCrypto, "Root certificate store is not accessible")]
public static void FindByValidThumbprint_RootCert()
{
Expand Down
1 change: 0 additions & 1 deletion ...ography.X509Certificates/tests/System.Security.Cryptography.X509Certificates.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
</PropertyGroup>
<Import Project="$(CommonPath)System\Security\Cryptography\Asn1Reader\System.Security.Cryptography.Asn1Reader.Shared.projitems" />
<ItemGroup>
<Compile Include="AssemblyInfo.cs" />
<Compile Include="$(CommonPath)System\Memory\PointerMemoryManager.cs"
Link="Common\System\Memory\PointerMemoryManager.cs" />
<Compile Include="$(CommonPath)System\Security\Cryptography\CryptoPool.cs"
Expand Down
1 change: 0 additions & 1 deletion src/libraries/System.Security.Cryptography.X509Certificates/tests/X509StoreTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,7 +426,6 @@ public static void OpenMachineRootStore_Permissions(OpenFlags permissions, bool
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/57506", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime), nameof(PlatformDetection.IsMariner))]
[SkipOnPlatform(PlatformSupport.MobileAppleCrypto, "Root certificate store is not accessible")]
public static void MachineRootStore_NonEmpty()
{
Expand Down