Update MsQuic and use ConnectionCloseStatus in StreamShutdown #73563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/ncl |
|
Interestingly enough, the current version when building main already reports 2.1.0, and since CI does not crash, it seems to be recent enough version. |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
CarnaViire
reviewed
Aug 9, 2022
src/libraries/System.Net.Quic/src/System/Net/Quic/QuicStream.cs
Outdated
Show resolved
Hide resolved
ManickaP
reviewed
Aug 9, 2022
| @@ -543,12 +543,12 @@ private unsafe int HandleEventShutdownComplete(ref SHUTDOWN_COMPLETE data) | |||
| (shutdownByApp: true, closedRemotely: true) => ThrowHelper.GetConnectionAbortedException((long)data.ConnectionErrorCode), | |||
| // It's local shutdown by app, this side called QuicConnection.CloseAsync, throw QuicError.OperationAborted. | |||
| (shutdownByApp: true, closedRemotely: false) => ThrowHelper.GetOperationAbortedException(), | |||
| // It's remote shutdown by transport, (TODO: we should propagate transport error code), throw QuicError.InternalError. | |||
| // TODO: we should propagate transport error code | |||
There was a problem hiding this comment.
Is the removal of the description // It's remote shutdown by transport, in the comment intentional? I don't mind it since the named variables are pretty self-explanatory. But if we're doing it, could you do it for all the cases?
There was a problem hiding this comment.
I added the comments back, with very brief explanation when the two transport shutdown cases occur.
|
Test failures are unrelated |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #73229.
This PR consumes latest MsQuic changes (2.1.0).
Opening as Draft until dependencies updates are merged (#72934). Unit tests pass with locally built MsQuic release/2.1 branch.