Change to GetLastPInvokeError where possible #73980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-meta Issue DetailsWe added This now uses it whereever it's available. No functional change.
|
danmoseley
force-pushed
the
fix.getlastpinvoke
branch
from
c27f665
to
673b957
Compare
stephentoub
reviewed
Aug 16, 2022
|
Hmm, I did "build libs -allconfigurations".. is there more? We will see. |
|
Oh! Tests too. |
danmoseley
force-pushed
the
fix.getlastpinvoke
branch
from
673b957
to
53312ad
Compare
|
@stephentoub looks like it's going to build - do you want to sign off? |
stephentoub
approved these changes
Aug 18, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added
Marshal.GetLastPInvokeError()a while back, and madeGetLastWin32Error()an alias for it, in order to reduce the use of "Win32" in non Windows contexts.This now uses it whereever it's available. No functional change.