Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport crossgen2 fix for musl-libc #73986

Merged
merged 2 commits into from
Sep 7, 2022

Conversation

am11
Copy link
Member

@am11 am11 commented Aug 16, 2022

Customer Impact

On the operating systems using musl-libc, some of the compiled binaries such as crossgen2 were incorrectly linked with glibc and that forces the consumer to install glibc on those systems (which is unintended as rest of the runtime artifacts are linked to musl-libc). The issue is that we are not taking libc flavor into account when calculating the OS value in 6.0.

Testing

This fix is tested on 7.0. This fix was made during the addition of another libc flavor (bionic-libc), in order to diversify the OS calculation. I have done some sanity testing locally, but not the entire platform matrix which uses cross-building. I will wait for the CI results.

Risk

Low. When CI legs are green, that will indicate that the platforms for which we cross-compile and run tests in Helix are largely unaffected. However, we need to make sure that crossgen2 binary is in working condition on those platforms since we are lacking tests for cross-compiled, crossgen2 binary.

Fixes #73908

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Aug 16, 2022
@ghost
Copy link

ghost commented Aug 16, 2022

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Customer Impact

On the operating systems using musl-libc, some of the compiled binaries such as crossgen2 are linked with glibc and that forces the consumer to install glib on the system (which is unintended as rest of the artifacts are linked to musl-libc). The issue is that we are not taking libc flavor into account when calculating the OS value in 6.0.

Testing

This fix is tested on 7.0. This fix was made during the addition of another libc flavor (bionic-libc), in order to diversify the OS calculation. I have done some sanity testing locally, but not the entire platform matrix which uses cross-building. I will wait for the CI results.

Risk

Low. When CI legs are green, that will indicate that the platforms for which we cross-compile and run tests in Helix are largely unaffected. However, we need to make sure that crossgen2 binary is in working condition on those platforms since we are lacking tests for cross-compiled, crossgen2 binary.

Fixes #73908

Author: am11
Assignees: -
Labels:

area-crossgen2-coreclr, area-Infrastructure, community-contribution

Milestone: -

Copy link
Member

@hoyosjs hoyosjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@akoeplinger
Copy link
Member

cc @carlossanlop

@hoyosjs
Copy link
Member

hoyosjs commented Aug 21, 2022

This is release/6.0 - we decided this change can wait for the next train.

@akoeplinger akoeplinger added this to the 6.0.x milestone Aug 22, 2022
@carlossanlop
Copy link
Member

Branding has been completed, so the branch is open again for changes. Merging since it got approved.

@carlossanlop carlossanlop merged commit 849fe98 into dotnet:release/6.0 Sep 7, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Oct 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants