[Mono] Only enable Arm intrinsics for full aot mode #74301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanyang-mono
requested review from
vargaz,
lambdageek and
SamMonoRT
as code owners
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lambdageek
reviewed
Aug 22, 2022
src/mono/mono/mini/simd-intrinsics.c
Outdated
| @@ -718,6 +718,14 @@ emit_hardware_intrinsics ( | |||
| if (!info) | |||
| goto support_probe_complete; | |||
| id = info->id; | |||
|
|
|||
| #ifdef TARGET_ARM64 | |||
| if (!(cfg->compile_aot && cfg->full_aot)) { | |||
There was a problem hiding this comment.
I think this also needs to check cfg->interp:
Suggested change
| if (!(cfg->compile_aot && cfg->full_aot)) { | |
| if (!(cfg->compile_aot && cfg->full_aot && !cfg->interp)) { |
Also, not sure if we should enable this for llvmonly, too. @vargaz what do you think?
lambdageek
approved these changes
Aug 22, 2022
|
/backport to release/7.0-rc1 |
|
Started backporting to release/7.0-rc1: https://github.com/dotnet/runtime/actions/runs/2905537115 |
|
This is ready to be merged. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #73003