Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mono] Only enable Arm intrinsics for full aot mode #74301

Merged
merged 2 commits into from
Aug 23, 2022

Conversation

fanyang-mono
Copy link
Member

Fix #73003

@fanyang-mono
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@lambdageek lambdageek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to also check that we're not in --aot=full,interp mode.

src/mono/mono/mini/simd-intrinsics.c Show resolved Hide resolved
@@ -718,6 +718,14 @@ emit_hardware_intrinsics (
if (!info)
goto support_probe_complete;
id = info->id;

#ifdef TARGET_ARM64
if (!(cfg->compile_aot && cfg->full_aot)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this also needs to check cfg->interp:

Suggested change
if (!(cfg->compile_aot && cfg->full_aot)) {
if (!(cfg->compile_aot && cfg->full_aot && !cfg->interp)) {

Also, not sure if we should enable this for llvmonly, too. @vargaz what do you think?

@lambdageek
Copy link
Member

/backport to release/7.0-rc1

@github-actions
Copy link
Contributor

Started backporting to release/7.0-rc1: https://github.com/dotnet/runtime/actions/runs/2905537115

@SamMonoRT
Copy link
Member

This is ready to be merged.

@SamMonoRT SamMonoRT merged commit 9528e6f into dotnet:main Aug 23, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.NET 7 exception on Android with EnableLLVM=true
3 participants