Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable VerifyXmlResolver test. #74417

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

eiriktsarpalis
Copy link
Member

@eiriktsarpalis eiriktsarpalis commented Aug 23, 2022

Address #74115 blocking CI. Should be backported to release/7.0

cc @krwq @GrabYourPitchforks

@eiriktsarpalis eiriktsarpalis self-assigned this Aug 23, 2022
@eiriktsarpalis eiriktsarpalis added this to the 8.0.0 milestone Aug 23, 2022
@ghost
Copy link

ghost commented Aug 23, 2022

Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

Address #74115 blocking CI.

cc @krwq @GrabYourPitchforks

Author: eiriktsarpalis
Assignees: -
Labels:

area-System.Security

Milestone: -

Comment on lines 1595 to +1596
[InlineData(true)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/74115")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If only true is failing, it seems worthwhile to only suppress true:

Suggested change
[InlineData(true)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/74115")]
//[InlineData(true)] [ActiveIssue("https://github.com/dotnet/runtime/issues/74115")]

@eiriktsarpalis eiriktsarpalis merged commit 97613f3 into dotnet:main Aug 23, 2022
@eiriktsarpalis
Copy link
Member Author

/backport to release/7.0

@eiriktsarpalis eiriktsarpalis deleted the disable-failing-xml-test branch August 23, 2022 18:06
@github-actions
Copy link
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/2913742956

@github-actions
Copy link
Contributor

@eiriktsarpalis backporting to release/7.0 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Patch format detection failed.
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@bartonjs
Copy link
Member

Aren't we backporting to (e.g.) release/7.0-rc1 and that then auto-ports to release/7.0?

@eiriktsarpalis
Copy link
Member Author

/backport to release/7.0-rc1

@github-actions
Copy link
Contributor

Started backporting to release/7.0-rc1: https://github.com/dotnet/runtime/actions/runs/2913779720

@github-actions
Copy link
Contributor

@eiriktsarpalis backporting to release/7.0-rc1 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Patch format detection failed.
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@ghost ghost locked as resolved and limited conversation to collaborators Sep 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants