-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Outerloop fix for libraries #74468
Outerloop fix for libraries #74468
Conversation
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue Detailsnull
|
@ViktorHofer The other option is to have libs.pretest imply hosts.native (which is more UX friendly). I don't see libs.pretest getting used in outer loop so I fixed it here. The outerloop is at a 100% failure rate since #73095 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's please first sync up so that I understand this change. The libraries' build-job should not declare the host.native dependency but the clr should. Why is host.native missing in outerloop?
So yes, this matches what I expected. This change would cause the host to be overbuilt. Once in the libraries build step and once in the run tests step. Not that much of an issue as both steps happen on the same machine but its resources that we would waste. Instead I think the fix is to make sure that the host gets built in the libraries' outerloop.yml. Will take a look tomorrow. |
This pull request has been automatically marked |
Still on my TODO list but need to finish 7.0 deliverables in the SDK first. |
This pull request has been automatically marked |
I will take a look when pending .NET 7 work is completed (roughly two more weeks). |
This pull request has been automatically marked |
This pull request will now be closed since it had been marked |
No description provided.