Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outerloop fix for libraries #74468

Closed
wants to merge 1 commit into from
Closed

Outerloop fix for libraries #74468

wants to merge 1 commit into from

Conversation

hoyosjs
Copy link
Member

@hoyosjs hoyosjs commented Aug 24, 2022

No description provided.

@ghost
Copy link

ghost commented Aug 24, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: hoyosjs
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@hoyosjs
Copy link
Member Author

hoyosjs commented Aug 24, 2022

@ViktorHofer The other option is to have libs.pretest imply hosts.native (which is more UX friendly). I don't see libs.pretest getting used in outer loop so I fixed it here. The outerloop is at a 100% failure rate since #73095

Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's please first sync up so that I understand this change. The libraries' build-job should not declare the host.native dependency but the clr should. Why is host.native missing in outerloop?

@ghost ghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Aug 24, 2022
@carlossanlop carlossanlop self-requested a review August 24, 2022 16:51
@ViktorHofer
Copy link
Member

So yes, this matches what I expected. This change would cause the host to be overbuilt. Once in the libraries build step and once in the run tests step. Not that much of an issue as both steps happen on the same machine but its resources that we would waste. Instead I think the fix is to make sure that the host gets built in the libraries' outerloop.yml.

Will take a look tomorrow.

@ghost
Copy link

ghost commented Sep 7, 2022

This pull request has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.

@ViktorHofer
Copy link
Member

Still on my TODO list but need to finish 7.0 deliverables in the SDK first.

@ghost ghost removed the no-recent-activity label Sep 8, 2022
@hoyosjs hoyosjs marked this pull request as draft September 8, 2022 18:37
@ghost ghost added the no-recent-activity label Sep 22, 2022
@ghost
Copy link

ghost commented Sep 22, 2022

This pull request has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.

@ViktorHofer
Copy link
Member

I will take a look when pending .NET 7 work is completed (roughly two more weeks).

@ghost
Copy link

ghost commented Oct 19, 2022

This pull request has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.

@ghost
Copy link

ghost commented Nov 2, 2022

This pull request will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the pull request, but please note that it will be locked if it remains inactive for another 30 days.

@ghost ghost closed this Nov 2, 2022
@hoyosjs hoyosjs deleted the juhoyosa/libs-outerloop branch November 3, 2022 18:39
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2022
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-libraries needs-author-action An issue or pull request that requires more info or actions from the author. no-recent-activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants