-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address Sanitizer support in CoreCLR #74623
Merged
Merged
Changes from 53 commits
Commits
Show all changes
59 commits
Select commit
Hold shift + click to select a range
e0c4a60
Enable AddressSanitizer in CoreCLR, Libs, and Host and update runtime…
jkoritzinsky 6fc2555
Unify on HAS_ADDRESS_SANITIZER define name
jkoritzinsky d7fe870
Remove CRT runtime changes. We won't need this when we finally onboar…
jkoritzinsky 007da09
Remove suppression now that we've fixed the underlying issue.
jkoritzinsky 8d3615d
Remove some Windows-only sanitizer CMake that we won't need when ASAN…
jkoritzinsky 92c4858
Set schedule for runtime-sanitized pipeline
jkoritzinsky a1f9900
Remove workaround in JIT memory set/copy helpers now that the JIT bug…
jkoritzinsky 2978de4
Add missing helix queues setup template.
jkoritzinsky 203e70c
Fix missing command to build nativeaot runtime tests as nativeaot.
jkoritzinsky eb9bf22
Add a scenario name to trigger the extended timeout in the libraries …
jkoritzinsky 413410b
Remove extraneous whitespace.
jkoritzinsky da30efe
Fix using the cross-targetting ILC when sanitizers are enabled. Also …
jkoritzinsky b99fab9
Merge branch 'main' of github.com:dotnet/runtime into asan
jkoritzinsky cd167b3
Disable LSAN on the CustomMain test.
jkoritzinsky 8fcc66f
Disable some tests on sanitized runtimes.
jkoritzinsky 931f444
Copy the sanitizer runtime for OSX NativeAOT runtime tests.
jkoritzinsky 6732866
Merge branch 'main' of github.com:dotnet/runtime into asan
jkoritzinsky 3c7dd54
A little cleanup to try to get the build right now that we are always…
jkoritzinsky 04d2d9f
Fix crossgen-corelib.proj syntax.
jkoritzinsky 97c848f
Merge branch 'main' of github.com:dotnet/runtime into asan
jkoritzinsky 9946108
Fix cross-os dac builds to not include the host architecture in the o…
jkoritzinsky 982e701
Split the debugger components into a separate component and make the …
jkoritzinsky 6239952
Merge branch 'asan' of /mnt/e/source/runtime into asan
jkoritzinsky 6769613
Always write out the host-arch path on Windows and update the cross-d…
jkoritzinsky 35d9bd7
Change to use the dynamic runtime on Windows, as ASAN in VS is moving…
jkoritzinsky 8b19fd3
Merge branch 'asan' of github.com:jkoritzinsky/runtime into asan
jkoritzinsky 5ae90d3
Update docker images to include the sanitizer runtimes in the crossro…
jkoritzinsky 647f73b
Merge branch 'main' of github.com:dotnet/runtime into asan
jkoritzinsky 5873281
Fix explicit image tags
jkoritzinsky d996328
The unsanitized build should be of the target architecture, not the h…
jkoritzinsky 2e452d4
Merge branch 'main' into asan
jkoritzinsky 2130d7b
Merge branch 'asan' of github.com:jkoritzinsky/runtime into asan
jkoritzinsky dc26f51
Turn off using the sigaltstack for NativeAOT tests that don't use the…
jkoritzinsky 6cc6ad8
Make sure the shared ASAN runtime is present for the nativeaot/SmokeT…
jkoritzinsky 591093e
Disable crossgen2 tests with sanitizers as they don't get us interest…
jkoritzinsky d285048
Merge branch 'main' of github.com:dotnet/runtime into asan
jkoritzinsky 7187ff2
Fix custom default options and disable some more crossgen2-based tests.
jkoritzinsky 6448d19
Simplify lookup of asan runtime on mac and fix copying the shared run…
jkoritzinsky 113f5b2
Merge branch 'asan' of github.com:jkoritzinsky/runtime into asan
jkoritzinsky 11cccdf
Disable test that's failing for weird reasons.
jkoritzinsky c0357af
Merge branch 'main' of github.com:dotnet/runtime into asan
jkoritzinsky 133e99b
Fix one more alloc-dealloc mismatch that only started to show up afte…
jkoritzinsky b863d6f
Disable the System.Text.Json test suite on sanitized builds as it cau…
jkoritzinsky 8a51e72
Merge branch 'main' of github.com:dotnet/runtime into asan
jkoritzinsky 98ed710
Fix test exclusion
jkoritzinsky 4efdf96
Merge branch 'main' of github.com:dotnet/runtime into asan
jkoritzinsky 6855c78
Merge branch 'main' of github.com:dotnet/runtime into asan
jkoritzinsky db5b069
Merge branch 'main' of github.com:dotnet/runtime into asan
jkoritzinsky 6383866
PR feedback.
jkoritzinsky 0f0fdf5
Merge remote-tracking branch 'dotnet/main' into asan
jkoritzinsky 36a450e
Fix mac build
jkoritzinsky f6987ed
Merge branch 'main' into asan
jkoritzinsky 619966b
Do review changes
jkoritzinsky 929a042
Add libbootstrapper object files to the platform manifest now that Na…
jkoritzinsky 5913ca4
Disable tests that check size on sanitized builds
jkoritzinsky b8b3762
Use the built-in `include_guard` option
jkoritzinsky c2433e5
Merge branch 'main' of github.com:dotnet/runtime into asan
jkoritzinsky fa15f17
Disable use-after-return checking in ASAN. CoreCLR doesn't do well wi…
jkoritzinsky 757a329
Only pass the no UAR flag on C and CXX with Clang (not AppleClang).
jkoritzinsky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do? I can guess, but I was having trouble finding references to
UndefineProperties
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UndefineProperties
removes the listed global properties from the list of global properties for the nested MSBuild invocation.I'm not sure where the documentation lives. I may have found this by trawling through the MSBuild source code.