Disallow IND<struct> except as a source of STORE_DYN_BLK
#74784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsNamely, the code which was wrapping temps created for calls. The only case remaining is the "original" wrapping, it will take a bit more work to get rid of it without regressions. Also perform a bit of miscellaneous code cleanup. We're expecting mostly positive diffs, with some regressions from the common sources:
|
SingleAccretion
force-pushed
the
impNormStructVal
branch
2 times, most recently
from
0df0121 to
ea85b39
Compare
SingleAccretion
force-pushed
the
impNormStructVal
branch
6 times, most recently
from
e307c88 to
0b9acb3
Compare
SingleAccretion
changed the title
OBJ(ADDR(...)) wrapping from impNormStructVal
SingleAccretion
force-pushed
the
impNormStructVal
branch
from
7705695 to
30406b3
Compare
Closed
SingleAccretion
force-pushed
the
impNormStructVal
branch
from
638db72 to
af99572
Compare
SingleAccretion
force-pushed
the
impNormStructVal
branch
3 times, most recently
from
6bb7f02 to
0fa4c9c
Compare
|
@dotnet/jit-contrib |
|
/azp run runtime-coreclr superpmi-diffs, runtime-coreclr superpmi-replay |
|
Azure Pipelines successfully started running 2 pipeline(s). |
SingleAccretion
force-pushed
the
impNormStructVal
branch
from
0fa4c9c to
9dc16fb
Compare
SingleAccretion
force-pushed
the
impNormStructVal
branch
from
9dc16fb to
a00a3f7
Compare
jakobbotsch
approved these changes
Dec 15, 2022
|
Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing for the removal of some
OBJ(ADDR(FIELD))wrapping inimpNormStructValand others.The diffs are expected to be positive: we now allow
FIELD<struct>substitution into struct args. There are a small number of regressions in CG collections that arise due to the fact unused R2R-affectedFIELDcall arguments interact less favorably with HIR DCE thanOBJ(ADDR(FIELD)): the latter would be reduced toADDR(FIELD), which would then null-check the object directly instead of expanding into theNULLCHECK(ADD(obj, IND(...))tree that the compiler cannot remove.