Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use IndexOf in NamespaceCache.SynthesizeNamespaceData #75319

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Use IndexOf in NamespaceCache.SynthesizeNamespaceData #75319

merged 1 commit into from
Sep 9, 2022

Conversation

stephentoub
Copy link
Member

No description provided.

@ghost ghost assigned stephentoub Sep 9, 2022
@ghost
Copy link

ghost commented Sep 9, 2022

Tagging subscribers to this area: @dotnet/area-system-reflection-metadata
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: stephentoub
Assignees: stephentoub
Labels:

area-System.Reflection.Metadata
Milestone: -

danmoseley
danmoseley approved these changes Sep 9, 2022
View reviewed changes
Copy link
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would a Count(T) method on Span<T> be worthwhile?

@gfoidl
Copy link
Member

gfoidl commented Sep 9, 2022

Would a Count(T) method on Span<T> be worthwhile?

Kind of popcount for Span.
Thus such an implementation could be vectorized quite easily.

@stephentoub
Copy link
Member Author

That's #59466

@stephentoub
Copy link
Member Author

Failure is #75329

@stephentoub stephentoub merged commit 14f3430 into dotnet:main Sep 9, 2022
@stephentoub stephentoub deleted the namespacecacheindexof branch September 9, 2022 13:21
@ghost ghost locked as resolved and limited conversation to collaborators Oct 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danmoseley danmoseley danmoseley approved these changes

Assignees

@stephentoub stephentoub

Labels
area-System.Reflection.Metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephentoub @gfoidl @danmoseley