Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dictionary perf regression for non-string ref type keys #75663

Merged
merged 7 commits into from
Sep 23, 2022
+209 −342
Merged

Fix Dictionary perf regression for non-string ref type keys #75663

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f5d5e3a
Fix Dictionary perf regression for non-string ref type keys
stephentoub Sep 15, 2022
9f402a5
Address PR feedback
stephentoub Sep 15, 2022
9851911
Fix one more existing TODO
stephentoub Sep 15, 2022
3a27103
Revert previous PR feedback changes
stephentoub Sep 16, 2022
b746387
Address PR feedback
stephentoub Sep 16, 2022
48d6ca0
Merge branch 'dotnet:main' into dictcomparer
stephentoub Sep 16, 2022
00ce044
Merge branch 'dotnet:main' into dictcomparer
stephentoub Sep 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ollections/tests/Generic/Dictionary/Dictionary.Generic.Tests.ConcurrentAccessDetection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ public async Task DictionaryConcurrentAccessDetection_ReferenceTypeKey(Type comp
IEqualityComparer<DummyRefType> customComparer = null;

Dictionary<DummyRefType, DummyRefType> dic = comparerType == null ?
new Dictionary<DummyRefType, DummyRefType>() :
new Dictionary<DummyRefType, DummyRefType>((customComparer = EqualityComparer<DummyRefType>.Default)) :
new Dictionary<DummyRefType, DummyRefType>((customComparer = (IEqualityComparer<DummyRefType>)Activator.CreateInstance(comparerType)));

var keyValueSample = new DummyRefType() { Value = 1 };
Expand Down
Loading